Hi Jukka,
> src/sim.c | 50 +++++++++++++++++++++++++++++++-------------------
> 1 files changed, 31 insertions(+), 19 deletions(-)
>
> diff --git a/src/sim.c b/src/sim.c
> index d627647..86c3f13 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -78,6 +78,8 @@ struct ofono_sim {
> gboolean barred_dialing;
>
> char *imsi;
> + char mcc[OFONO_MAX_MCC_LENGTH + 1];
> + char mnc[OFONO_MAX_MNC_LENGTH + 1];
so I would split this a little bit.
1) refactor src/sim.c to store mcc and mnc.
2) add header definitions
3) add getters implementation.
And send these separately. No need to make them part of the provision
patch set. I know that you need them for that, but they are not really
required and could be reviewed and applied quicker.
Regards
Marcel
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
