Hi Jukka,
<snip>
> +/*
> + * Callback from provisioning plugin.
> + * settings: list of struct ofono_gprs_provision_data
> + *
> + * It is responsibility of callback function to free settings-list
> + * settings-list elements must be freed with ofono_gprs_provision_data_free()
> + */
> +typedef void (*ofono_gprs_provision_cb_t)(GSList *settings, void *userdata);
so our general rule is no GLib types in oFono public APIs.
> +struct ofono_gprs_provision_driver {
> + const char *name;
> + int priority;
> + int (*probe)(struct ofono_gprs_provision_context *context);
> + void (*remove)(struct ofono_gprs_provision_context *context);
> + void (*get_settings) (struct ofono_gprs_provision_context *context,
No space between (get_settings) and (struct please.
> + ofono_gprs_provision_cb_t cb,
> + void *user_data);
> +};
> +
> +/* For provisioning drivers/plugins */
> +int ofono_gprs_provision_driver_register(
> + const struct ofono_gprs_provision_driver *driver);
> +void ofono_gprs_provision_driver_unregister(
> + const struct ofono_gprs_provision_driver *driver);
> +
> +/* For gprs */
> +void ofono_gprs_provision_data_free(struct ofono_gprs_provision_data *data);
This sounds more like an __ofono_* internal API kind of thing.
Regards
Marcel
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
