Hi Denis,
On 02/05/2016 17:13, Denis Kenzior wrote:
>
>>
>> diff --git a/plugins/gobi.c b/plugins/gobi.c
>> index 4daa459..09c9d95 100644
>> --- a/plugins/gobi.c
>> +++ b/plugins/gobi.c
>> @@ -413,12 +413,16 @@ error:
>> static void gobi_pre_sim(struct ofono_modem *modem)
>> {
>> struct gobi_data *data = ofono_modem_get_data(modem);
>> + const char * simdriver;
>>
>> DBG("%p", modem);
>>
>> ofono_devinfo_create(modem, 0, "qmimodem", data->device);
>>
>> - if (data->features & GOBI_UIM)
>> + simdriver = ofono_modem_get_string(modem,"Simdriver");
>
> Can we name this ForceSimLegacy and make it a boolean?
>Yes of course. Actually, it was my first implementation ... and then, I thought this type of "overload" can be interested for other modem drivers. So I tried to make it generic through a string. But I agree using a boolean is simplier and more reliable (avoid the use of an unregistered driver). > > Regards, > -Denis > Thanks, Martin
signature.asc
Description: OpenPGP digital signature
_______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
