Hi Martin,
On 05/02/2016 11:33 AM, Martin Chaplet wrote:
Let modem detect part overload default SIM driver by using an additional
property named "ForceSimLegacy" (boolean).
Signed-off-by: Martin Chaplet <[email protected]>
No Signed-off-by please.
---
plugins/gobi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/gobi.c b/plugins/gobi.c
index 4daa459..aad423d 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -418,7 +418,7 @@ static void gobi_pre_sim(struct ofono_modem *modem)
ofono_devinfo_create(modem, 0, "qmimodem", data->device);
- if (data->features & GOBI_UIM)
+ if ( (data->features & GOBI_UIM) && !ofono_modem_get_boolean(modem,
"ForceSimLegacy") )
Not our style. Also the logic would be cleaner if we do something like:
const char *sim_driver;
if (data->features & GOBI_UIM)
sim_driver = "qmimodem";
else if (data->features & GOBI_DMS)
sim_driver = "qmimodem-legacy";
if (ofono_modem_get_boolean(modem, "ForceSimLegacy"))
sim_driver = "qmimodem-legacy";
ofono_sim_create(...);
ofono_sim_create(modem, 0, "qmimodem", data->device);
else if (data->features & GOBI_DMS)
ofono_sim_create(modem, 0, "qmimodem-legacy", data->device);
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
