On Mon, 7 Aug 2017 12:42:55 -0500 Denis Kenzior <[email protected]> wrote:
Hi Dennis, > So this is not in line with our patch submission guidelines. See > HACKING... I'm sorry. I missed that one. Hopefully I got the coding style right so far. > We are not exposing glib into the oFono plugin API. So the use of > GSList, etc data structures across driver <-> core boundary is not > possible. The reasons are somewhat historic, but essentially > non-GLib based plugins must be possible. Also, oFono's use of GLib > will be replaced by ell [1] in the future. Interesting. Do you have any plans when and how the migratation will be done? > I'm still not quite sure what you're trying to solve with these > changes? A bit more info on the motivation of the patches in the > commit description would be helpful... My motivation is to get rid of the generic part in the modem drivers. E.g. look at the rild and atmodem, they have a lot similiar code when parsing the call list. So it would be nice to replace those. On the other side I've written a voicecall driver for qmi which is using the call list, but I'm still testing it. Best, Alex PS. I better had tagged this patch RFC... -- Alexander Couzens mail: [email protected] jabber: [email protected] mobile: +4915123277221 gpg: 390D CF78 8BF9 AA50 4F8F F1E2 C29E 9DA6 A0DF 8604
pgp5nfolp4qp_.pgp
Description: OpenPGP digital signature
_______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
