Hi Giacinto,
Your patch series has 7 commits with the same header. That is nonsense.
Each commit header should be specific to what is contained inside and
preferably followed by a commit description.
Read any one of the many 'How to submit a kernel patch' howtos in order
to understand the best practices here. oFono does not use Signed-off-by
lines and a few things are different, but the commit header/description
requirements and the overall patch submission process are the same.
On 09/19/2018 12:37 AM, Giacinto Cifelli wrote:
---
include/gprs-context.h | 1 +
include/lte.h | 11 +++++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
This really should be two patches because you're changing unrelated things.
diff --git a/include/gprs-context.h b/include/gprs-context.h
index 20ca9ef..8869c12 100644
--- a/include/gprs-context.h
+++ b/include/gprs-context.h
@@ -57,6 +57,7 @@ enum ofono_gprs_context_type {
enum ofono_gprs_auth_method {
OFONO_GPRS_AUTH_METHOD_CHAP = 0,
OFONO_GPRS_AUTH_METHOD_PAP,
+ OFONO_GPRS_AUTH_METHOD_NONE,
So strictly speaking we already support NONE as a method if username is
empty. I don't have a problem with this change, but it does imply that
you need to fix up the existing code depending on this enumeration to
behave properly.
};
struct ofono_gprs_primary_context {
diff --git a/include/lte.h b/include/lte.h
index ef84ab9..38587c3 100644
--- a/include/lte.h
+++ b/include/lte.h
@@ -3,6 +3,7 @@
* oFono - Open Source Telephony
*
* Copyright (C) 2016 Endocode AG. All rights reserved.
+ * Copyright (C) 2018 Gemalto M2M
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
@@ -28,14 +29,18 @@ extern "C" {
#include <ofono/types.h>
-struct ofono_lte;
-
So why are you changing the order seemingly randomly? And anyway, this
is wrong. See doc/coding-style.txt item M9.
struct ofono_lte_default_attach_info {
char apn[OFONO_GPRS_MAX_APN_LENGTH + 1];
+ enum ofono_gprs_proto proto;
+ enum ofono_gprs_auth_method auth_method;
+ char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1];
+ char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1];
Okay, but you might want to start at the D-Bus API level first...
};
typedef void (*ofono_lte_cb_t)(const struct ofono_error *error, void *data);
+struct ofono_lte;
+
struct ofono_lte_driver {
const char *name;
int (*probe)(struct ofono_lte *lte, unsigned int vendor, void *data);
@@ -61,6 +66,8 @@ void ofono_lte_set_data(struct ofono_lte *lte, void *data);
void *ofono_lte_get_data(const struct ofono_lte *lte);
+struct ofono_modem *ofono_lte_get_modem(const struct ofono_lte *lte);
+ > #ifdef __cplusplus
}
#endif
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
