Hi Denis,

On 31/05/2019, Denis Kenzior <[email protected]> wrote:
> Hi Philippe,
>
> Your indentation and coding style is all wrong here.

Well it was an RFC as in my cover letter I explained there were many
open issues I wondered about. Will clean it up when that  is clear
ofc.

>>   static void cfun_enable(gboolean ok, GAtResult *result, gpointer
>> user_data)
>>   {
>>      struct ofono_modem *modem = user_data;
>> @@ -261,7 +314,7 @@ static int ublox_enable(struct ofono_modem *modem)
>>       * the 'Device' attribute instead...
>>       */
>>      if (data->aux == NULL) {
>> -            data->aux = open_device(modem, "Device", "Aux: ");
>> +            data->aux = open_serial_device(modem, "Device", "Aux: ");
>
> Tell me how you're driving a serial device without setting up a
> multiplexer.
>

Seems to work fine. Trying to set up a mux freezes the modem so... it
could however be I have misunderstood something though.

Regards,

Philippe
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to