Hi Philippe,
On 06/05/2019 07:37 AM, Philippe De Swert wrote:
Hi Denis,
On 31/05/2019, Denis Kenzior <[email protected]> wrote:
Hi Philippe,
Your indentation and coding style is all wrong here.
Well it was an RFC as in my cover letter I explained there were many
open issues I wondered about. Will clean it up when that is clear
ofc.
We (like other major projects, which are even more so) are very
particular about coding style. And it is good form (and to your
advantage) to have your submissions follow that, regardless of whether
they're RFC or not.
static void cfun_enable(gboolean ok, GAtResult *result, gpointer
user_data)
{
struct ofono_modem *modem = user_data;
@@ -261,7 +314,7 @@ static int ublox_enable(struct ofono_modem *modem)
* the 'Device' attribute instead...
*/
if (data->aux == NULL) {
- data->aux = open_device(modem, "Device", "Aux: ");
+ data->aux = open_serial_device(modem, "Device", "Aux: ");
Tell me how you're driving a serial device without setting up a
multiplexer.
Seems to work fine. Trying to set up a mux freezes the modem so... it
could however be I have misunderstood something though.
'Seems to work' isn't the right answer :) In short: you need a
multiplexer for a serial device with a single tty.
The reason for that is that once you enter data mode (PPP or whatever)
on your serial port, all other AT command communication with the modem
stops. So you are not sending SMSs, receiving signal strength updates, etc.
So unless I'm missing something, the first step for you is to figure out
how to get the multiplexer going first. Since you intend to use PPP,
there has to be at least two logical AT command ports for the device to
be useful (one for PPP and one for AT commands). More if you want to
support multiple context activations, though with PPP that is unlikely.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
