Hi,
first of all, thanks for the review!
The current structure of the commits is purely for historical reasons,
since this is a collection of patches by different people that are all
required for the Qt5 port. The Signed-off-by exist for the same reason,
because the people who originally did the affected patches used them.
If you want I can squash them together and group the changes into a
commit by content, not by author.
Am 29.10.19 um 17:06 schrieb Denis Kenzior:
Hi Jonah,
On 10/27/19 11:30 AM, Jonah Brüchert wrote:
From: Simon Busch <[email protected]>
Signed-off-by: Simon Busch <[email protected]>
Signed-off-by: Martin Jansa <[email protected]>
We don't use Signed-off-by, so please drop this in the future.
---
Makefile.am | 2 +-
configure.ac | 6 +++---
src/control.cpp | 4 ++--
src/qsimcommand.cpp | 2 +-
src/qsmsmessage.cpp | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
In general we prefer the commits to be separated out between build
changes and actual code changes.
diff --git a/Makefile.am b/Makefile.am
index 2a6fccf..8c99b04 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -46,7 +46,7 @@ nodist_src_phonesim_SOURCES = src/ui_controlbase.h \
src_phonesim_LDADD = $(QT_LIBS)
-AM_CXXFLAGS = -Wall $(QT_CFLAGS)
+AM_CXXFLAGS = -Wall $(QT_CFLAGS) -fPIC -fPIE
You set -fPIE here but remove it in patch 6. Do you want to squash
these two together?
AM_CPPFLAGS = -I$(top_srcdir)/src -I$(top_builddir)/src
Regards,
-Denis
_______________________________________________
ofono mailing list -- [email protected]
To unsubscribe send an email to [email protected]
