Hi Denis,
Thank you very much for applying the patches!
As mentioned earlier I have worked on a few additional commits to
completely replace all deprecated Qt APIs.
This is not strictly required until Qt6 is released, but will basically
allow to run on Qt6 right when it's released with just a few build
system changes.
If you are interested, just let me know when you have time to review
those as adding those patches is obviously not urgent.
In addition I added a cmake build system which allowed me to work with
Qt's QtCreator IDE, but I can very well understand if you don't want to
switch the build system and would leave that patch out.
I pushed the patches to KDE's GitLab instance
https://invent.kde.org/jbbgameich/ofono-phonesim/commits/master for now,
but would of course send them to the mailing list for review later.
Kind regards,
Jonah
Hi Jonah,
On 10/30/19 3:37 PM, Jonah Brüchert wrote:
From: Simon Busch <[email protected]>
Co-authored-by: Martin Jansa <[email protected]>
Co-authored-by: Jonah Brüchert <[email protected]>
Co-authored-by: Alexander Akulich <[email protected]>
---
Makefile.am | 4 +++-
configure.ac | 15 ++++++++++++---
src/control.cpp | 4 ++--
src/phonesim.cpp | 2 +-
src/phonesim.h | 2 +-
src/qsimcommand.cpp | 2 +-
src/qsmsmessage.cpp | 6 +++---
src/server.cpp | 2 +-
src/server.h | 2 +-
9 files changed, 25 insertions(+), 14 deletions(-)
Sorry for the delay. Took me a bit to sort out Qt5 on my VM. Anyway,
the changes look fine to me and things still appear to work. So I
went ahead and pushed both of these patches out.
Regards,
-Denis
_______________________________________________
ofono mailing list -- [email protected]
To unsubscribe send an email to [email protected]
_______________________________________________
ofono mailing list -- [email protected]
To unsubscribe send an email to [email protected]
