Hefty, Sean wrote: >>>> cl_memclr --> NdisZeroMemory >>>> cl_memcpy --> NdisMoveMemory >>>> cl_memcmp --> memcmp >>>> cl_memset --> memset >>> >>> The latter should be RtlCompareMemory and RtlFillMemory. All of the >>> complib abstractions should eventually be replaced with the native >>> calls. >> >> Ndis* == Rtl* > > I think using the Ndis* calls for ipoib is correct. If there are > Ndis* calls for the other Rtl* routines I mentioned, ipoib should use > those. Otherwise, the Rtl* calls should be used in place of the C > lib routines or complib, with Rtl* used in all other kernel modules. > > I'm not suggesting to replace all of them now, just that these > changes move in that direction. For these patches, please replace > memcmp and memset with the Rtl* or corresponding Ndis* calls if those > exist. > > - Sean
Why is a call to Rtl* or Ndis* is superior to a compiler intrinsic? _______________________________________________ ofw mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
