On 30 September 2011 12:43, James Paige <[email protected]> wrote: > On Thu, Sep 29, 2011 at 04:39:56PM -0700, Adam Perry wrote: >> On Thu, Sep 29, 2011 at 4:37 PM, James Paige <[email protected]> >> wrote: >> > On Thu, Sep 29, 2011 at 04:25:52PM -0700, [email protected] >> > wrote: >> >> james >> >> 2011-09-29 16:25:52 -0700 (Thu, 29 Sep 2011) >> >> 169 >> >> Apply Mogri's patch (with a few fixes) for new commands: >> > >> > Your patch applied cleanly except for the plotdict.xml part, which I had >> > to manually apply. I don't know why >> > >> > You were missing the fourth argument of your bound_arg() calls, and I >> > had to change two FOR i = into FOR i as integer = >> > >> > I also added tests for all the new commands to testgame/autotest.hss >> > >> >> get door x >> > >> > This was perfect. >> > >> >> get door y >> > >> > the y in door links has an off-by-1 error left over from before 4-map >> > days. Really, I should fix the deserdoors() in loading.bas to adjust all >> > the door y values in one place at load time, and then it will no longer >> > be necessary to do - 1 all over the place. For now, I just added a -1 in >> > the implementation "of get door y" >> > >> >> get door destination id >> >> get door destination map >> > >> > These were not working when i added the tests in autotest.hss and it >> > took me a while to figure out why. I hadd to add a deserdoors call right >> > before each of them, because currently doorlinks get loaded when you try >> > to use a door, instead of loading when you load a map. This could be >> > fixed to make doors more efficient. >> > >> >> door is active >> > >> > I think this one works fine but honestly I didn't test it as vigorously >> > as the others :) >> > >> >> read attack caption >> > >> > You had readattackcaption(retvals(1) + 1) when it should have been >> > readattackcaption(retvals(1) - 1) >> > >> > ...anyway, you did good work for editing blind without being able to >> > compile :) (I am assuming you can't compile because then you would have >> > caugh the bound_arg and the FOR i as integer = mistakes ) >> > >> > Should I write up some better instructions for compiling the OHR on >> > Windows? >> >> No, the instructions are fine. I've compiled before. I actually did >> the editing on a Linux box -- I am hopeless without grep. I just don't >> have FB on that box or this machine. >> >> Thanks! > > Ah, cool! :) > > By the way, I miss grep whenever I am on a Windows box too. This bundle > makes me happy: > > http://sourceforge.net/projects/unxutils/files/unxutils/current/UnxUtils.zip/download > > --- > James
Real text editors (emacs) ship with grep -- and a special grep mode -- included :) I just made a few additional changes to this patch. Also I think you might have misunderstood the bit that 'door is active' was reading? Those indicate that the door has been placed on the map, not that it's currently linked to anything. I renamed it. Mostly my changes are just to change from the style you copied from the surrounding code (bound_arg uses errorlevel 4 by default, which means 'suppressed by default') to stricter error checking. _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
