On Fri, Sep 30, 2011 at 03:56:02PM +1300, Ralph Versteegen wrote: > On 30 September 2011 08:34, James Paige <[email protected]> wrote: > > On Thu, Sep 29, 2011 at 11:55:26AM -0700, Adam Perry wrote: > >> On Thu, Sep 29, 2011 at 11:26 AM, Adam Perry <[email protected]> wrote: > >> > I'd like to add in a few more plotscripting commands, but I'm not sure > >> > what files need to be changed. The obvious one is plotscr.hsd, and I'm > >> > sure I can figure out what to do there, but what other files are > >> > involved? > >> > > >> > I'm not looking to do anything complicated; just getters/setters for > >> > things like door position and enemy attacks. > >> > > >> > >> Actually, some research shows that enemy attacks are already exposed > >> (albeit via the arcane "read enemy data" command). So that's one down. > > > > Yes, the "read enemy data" commands are unfortunately arcane, and will > > be a backcompat pain in the future. > > I had been thinking recently: let's not support read/writeenemydata > for anything other than the provided constants. If you haven't used > them, and I haven't used them, and Mogri hasn't used them, then we can > be nearly sure that noone has.
I agree! Those commands should only continue to work for old data, we don't want to attempt to expand them. Once enemy data is in reload format, and plotscripting has arrays and strings, we can expose enemy data as some kind of beautiful simple associative key/value object. > > Getters and setters for door position, eh? > > Door setters are quite tricky, since we would want the changes to > persist if you save the map state, like all the other map data. This > involves updating a bunch of map loading and saving stuff, and also > the live previewing system which should also be adjusted to become > aware of script door edits, so it's probably better if I handled it. Yes, I was pleased that Mogri only attempted getters at this time :) --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
