@bob-the-hamster commented on this pull request.
> @@ -2722,7 +2738,7 @@ SUB show_victory (byref bat as BattleState, bslot() as
> BattleSprite, page as int
SELECT CASE .state
CASE vicGOLDEXP
'--print acquired gold and experience
- IF bat.rew.plunder > 0 OR bat.rew.exper > 0 THEN draw_victory_box 4, page
+ IF gen(genDefaultBattleMenu) >= 0 AND (bat.rew.plunder > 0 OR
bat.rew.exper > 0) THEN draw_victory_box 4, page
What is the reason for adding the `gen(genDefaultBattleMenu) >= 0` check here?
That should always return true, and doesn't seem relevant. Is this supposed to
use `genSkipBattleRewardsTicks` ?
(same comment for other usages of `genDefaultBattleMenu`)
--
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/pull/1283#pullrequestreview-3094273675
You are receiving this because you are subscribed to this thread.
Message ID: <ohrrpgce/ohrrpgce/pull/1283/review/[email protected]>_______________________________________________
Ohrrpgce mailing list
[email protected]
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
