rversteegen left a comment (ohrrpgce/ohrrpgce#1283)
Thanks! That's a substantial feature! Looks good and the reward code is
slightly cleaner for it. (`show_victory` is a bit of a mess. I have a branch
which makes some changes to it which I might as well merge after this PR while
we're at it.)
`RewardsState` should go in game_udts.bi rather than udts.bi.
One thing that is missing is that `gam.rew` (which we could name something
clearer) isn't reset when starting/loading a game. Adding `reset_rewards_state
gam.rew` in `reset_game_state` after `gam.wonbattle = NO` would be a sane place
for it. (Our initialisation is a mess; we ought to be calling the constructor
for GameState instead of manually resetting everything. `reset_reward_state`
even mentions "This could become a constructor for RewardsState when we support
the -lang fb dialect" which happened long ago.)
The script commands could mention that the rewards are reset after loading a
game, but that's probably too much information (`hero levelled` for example
doesn't).
--
Reply to this email directly or view it on GitHub:
https://github.com/ohrrpgce/ohrrpgce/pull/1283#issuecomment-3162183187
You are receiving this because you are subscribed to this thread.
Message ID: <ohrrpgce/ohrrpgce/pull/1283/[email protected]>
_______________________________________________
Ohrrpgce mailing list
[email protected]
http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
