That would be great!
Looks like the vast majority are unchecked fwrite() calls. Certainly it makes
sense to check the return code and take appropriate action (usually just
failing the OIIO call) if the write appears to fail.
-- lg
On Jul 9, 2012, at 1:10 PM, Kevin Brightwell wrote:
> Hi everyone,
>
> I don't get a chance to contribute often, but I could probably clean these
> up! I have been following the project for over a year (waiting for that
> moment when it is useful for me and I can be useful to it).
>
> I can look through and try to fix a lot of these, I'll submit a patch with
> what I get done.
>
> Cheers,
> Kevin
>
> On Mon, Jul 9, 2012 at 3:41 PM, Richard Shaw <[email protected]> wrote:
> On Mon, Jul 9, 2012 at 2:22 PM, Larry Gritz <[email protected]> wrote:
> > We do like to fix the warnings, but usually we make such changes to the
> > master branch and only fix important bugs in release branches. Though we
> > would happily backport if a particular warning is really getting in the way
> > of somebody who is stuck using a release.
> >
> > I'd be curious to hear if you do a build from master, whether most of those
> > warnings had already been fixed?
>
> Grepping through the log just for warnings, I actually got 121 lines
> in master but only 120 in 1.0.7. I assumed I pulled master correctly,
> I cheated and clicking on the link in github while the master branch
> was active. The strange thing is that the tarball generated had
> version 1.0.2 embedded in the tarball.
>
> The vast majority of the warnings[1] are of the:
>
> warning: ignoring return value of 'size_t fwrite(const void*, size_t,
> size_t, FILE*)', declared with attribute warn_unused_result
> [-Wunused-result]
>
> and the like. But if you need more context I added the line numbers
> from the full log[2] in the warning only log.
>
> Richard
>
> [1] https://dl.dropbox.com/u/34775202/build-warnings.log
> [2] https://dl.dropbox.com/u/34775202/build.log
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
>
>
> --
> Kevin Brightwell
> Year 4 Bachelor of Computer Engineering (BESc.)
> Year 3 Bachelor of Computer Science (BSc.)
> Residence Don - Saugeen-Maitland Hall
> Western University www.westernu.ca
> e. [email protected] c. 226.678.4927
>
> _______________________________________________
> Oiio-dev mailing list
> [email protected]
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
--
Larry Gritz
[email protected]
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
