Hi all,
Rather than start a new thread, here is the link to the pull request for
fixing the errors noted by Richard.
This fixes log files sent earlier today by @hobbes1069.
I can confirm most of them, but some files are not compiled as I do not
have some plugins compiling due to not having libraries. I tried my best to
match the warnings to the files that I had to do by hand, but I would not
be surprised in the least if I missed some.
In other thoughts, I feel as though this could be done much more elegantly.
<snip>See pull request</snip>
In one file, I was able to use a simple macro, but perhaps this is
something that could be addressed through an inline method or a better
defined set. Just some thoughts.
Oh, and all criticism is welcome, what ever there may be. I want to learn
more!
Log details:
$ git shortlog 4013938..c624285
Kevin Brightwell (7):
Sysutil::put_in_background -> returns true if fork was successful.
Fixes error where strncpy was copying max 200 chars which is greater
than
Fixes an unused variable. It was set to 0 then left there. I also
form
Fixed a small issue with defining INLINE, now will be recognized on
more p
Fixes two fread problems, both return false and act as other parts do.
Fixes two unused variables, similar: two booleans for printed that
were ig
Fixes all of the warnings in the .log supplied by Richard
(@hobbes1069)..
Pull Request: https://github.com/OpenImageIO/oiio/pull/396
Cheers,
Kevin
On Tue, Jul 10, 2012 at 12:15 AM, Kevin Brightwell <
[email protected]> wrote:
> Hi Larry,
>
> In looking through that section of the CMake file, it appears as though it
> relies on BOOST_ROOT (which was not set by default in the installer). When
> I was mucking about to try and fix that, I checked and both of the
> environment variables were undeclared. Strange, perhaps this is a bug for
> Ubuntu's package rather than worrying about it here.
>
> As a related aside: Boost 1.50 is out, so should that be added to:
> 85 set (Boost_ADDITIONAL_VERSIONS "1.49" "1.48" "1.47" "1.46" "1.45"
> "1.44"
> 86 "1.43" "1.43.0" "1.42" "1.42.0"
> 87 "1.41" "1.41.0" "1.40" "1.40.0")
>
> Cheers,
> Kevin
>
>
>
> On Tue, Jul 10, 2012 at 12:09 AM, Larry Gritz <[email protected]> wrote:
>
>> Is the problem that apt installed it in a directory where it was not
>> found by CMake in its search for Boost? If so, the best thing would be to
>> submit a pull request in which you add that directory (unless it's
>> something extremely custom that nobody else would ever see) to the list of
>> directories to search for Boost components. I think you can just add to
>> the find_package line in src/cmake/externalpackages.cmake file:
>>
>> find_package (Boost 1.40 REQUIRED
>> COMPONENTS filesystem regex system thread
>> PATHS /your/path/here
>> )
>>
>>
>>
>>
>> On Jul 9, 2012, at 5:51 PM, Kevin Brightwell wrote:
>>
>> I started on this, once I got the project compiling.
>>
>> I thought I should note this: On Ubuntu x86_64, I had to manually compile
>> and install boost to have CMake find it. I originally had libboost1.48-dev
>> installed using apt, but that was wasn't found.
>>
>> Not entirely sure where this should be posted as the
>> "build/troubleshooting" page on the Wiki appears blank.
>>
>> Cheers,
>> Kevin
>>
>> On Mon, Jul 9, 2012 at 5:02 PM, Larry Gritz <[email protected]> wrote:
>>
>>> That would be great!
>>>
>>> Looks like the vast majority are unchecked fwrite() calls. Certainly it
>>> makes sense to check the return code and take appropriate action (usually
>>> just failing the OIIO call) if the write appears to fail.
>>>
>>> -- lg
>>>
>>>
>>> On Jul 9, 2012, at 1:10 PM, Kevin Brightwell wrote:
>>>
>>> Hi everyone,
>>>
>>> I don't get a chance to contribute often, but I could probably clean
>>> these up! I have been following the project for over a year (waiting for
>>> that moment when it is useful for me and I can be useful to it).
>>>
>>> I can look through and try to fix a lot of these, I'll submit a patch
>>> with what I get done.
>>>
>>> Cheers,
>>> Kevin
>>>
>>> On Mon, Jul 9, 2012 at 3:41 PM, Richard Shaw <[email protected]>wrote:
>>>
>>>> On Mon, Jul 9, 2012 at 2:22 PM, Larry Gritz <[email protected]> wrote:
>>>> > We do like to fix the warnings, but usually we make such changes to
>>>> the master branch and only fix important bugs in release branches. Though
>>>> we would happily backport if a particular warning is really getting in the
>>>> way of somebody who is stuck using a release.
>>>> >
>>>> > I'd be curious to hear if you do a build from master, whether most of
>>>> those warnings had already been fixed?
>>>>
>>>> Grepping through the log just for warnings, I actually got 121 lines
>>>> in master but only 120 in 1.0.7. I assumed I pulled master correctly,
>>>> I cheated and clicking on the link in github while the master branch
>>>> was active. The strange thing is that the tarball generated had
>>>> version 1.0.2 embedded in the tarball.
>>>>
>>>> The vast majority of the warnings[1] are of the:
>>>>
>>>> warning: ignoring return value of 'size_t fwrite(const void*, size_t,
>>>> size_t, FILE*)', declared with attribute warn_unused_result
>>>> [-Wunused-result]
>>>>
>>>> and the like. But if you need more context I added the line numbers
>>>> from the full log[2] in the warning only log.
>>>>
>>>> Richard
>>>>
>>>> [1] https://dl.dropbox.com/u/34775202/build-warnings.log
>>>> [2] https://dl.dropbox.com/u/34775202/build.log
>>>> _______________________________________________
>>>> Oiio-dev mailing list
>>>> [email protected]
>>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>>>
>>>
>>>
>>>
>>> --
>>> Kevin Brightwell
>>> *Year 4 Bachelor of Computer Engineering (BESc.)
>>> Year 3 Bachelor of Computer Science (BSc.) *
>>> Residence Don - Saugeen-Maitland Hall
>>> Western University www.westernu.ca <http://www.uwo.ca/>
>>> e. [email protected] c. 226.678.4927
>>>
>>> _______________________________________________
>>> Oiio-dev mailing list
>>> [email protected]
>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>>
>>>
>>> --
>>> Larry Gritz
>>> [email protected]
>>>
>>>
>>>
>>> _______________________________________________
>>> Oiio-dev mailing list
>>> [email protected]
>>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>>
>>>
>>
>>
>> --
>> Kevin Brightwell
>> *Year 4 Bachelor of Computer Engineering (BESc.)
>> Year 3 Bachelor of Computer Science (BSc.) *
>> Residence Don - Saugeen-Maitland Hall
>> Western University www.westernu.ca <http://www.uwo.ca/>
>> e. [email protected] c. 226.678.4927
>>
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected]
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>
>>
>> --
>> Larry Gritz
>> [email protected]
>>
>>
>>
>> _______________________________________________
>> Oiio-dev mailing list
>> [email protected]
>> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>>
>>
>
>
> --
> Kevin Brightwell
> *Year 4 Bachelor of Computer Engineering (BESc.)
> Year 3 Bachelor of Computer Science (BSc.) *
> Residence Don - Saugeen-Maitland Hall
> Western University www.westernu.ca <http://www.uwo.ca>
> e. [email protected] c. 226.678.4927
>
>
--
Kevin Brightwell
*Year 4 Bachelor of Computer Engineering (BESc.)
Year 3 Bachelor of Computer Science (BSc.) *
Residence Don - Saugeen-Maitland Hall
Western University www.westernu.ca <http://www.uwo.ca>
e. [email protected] c. 226.678.4927
_______________________________________________
Oiio-dev mailing list
[email protected]
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
