Oh, I see, so CXX_VISIBILITY_PRESET is the name of the property that can be set on a target, but CMAKE_CXX_VISIBILITY_PRESET should be the name of the variable/option if we wish cmake to honor it by adding the property correctly everywhere?
Is that right? So the solution is to change the name of the cache variable? > On May 7, 2023, at 10:06 PM, Fabrice Macagno <fabrice.maca...@al.com.au> > wrote: > > Hi there, > I wanted to double check with you if the intention behind this statement > <https://github.com/OpenImageIO/oiio/blob/32a361ab3ed6479725f0b22d591a436728cfe640/src/cmake/compiler.cmake#L124> > is to expose only the symbols which have been explicitly flagged as public? > I'm asking because, on linux at least, this is not the outcome. > I use the CMAKE_CXX_VISIBILITY_PRESET > <https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_VISIBILITY_PRESET.html#variable:CMAKE_%3CLANG%3E_VISIBILITY_PRESET> > instead to achieve this behaviour. > -- > Fabrice Macagno (He/Him) > Technical Lead > > T: +61 2 9383 4800 (main) > D: +61 2 8063 2951 (direct) > E: fabrice.maca...@al.com.au <mailto:fabrice.maca...@al.com.au> > > Building 54, 38 Driver Ave > Moore Park, NSW 2021 > AUSTRALIA > > <https://www.linkedin.com/company/animal-logic> > <https://www.facebook.com/Animal-Logic-129284263808191/> > <https://twitter.com/AnimalLogic> > <https://www.instagram.com/animallogicstudios/> > > <http://www.animallogic.com/> > > Animal Logic acknowledges the Traditional Custodians, the Bidjigal people and > Gadigal people of the Eora Nation, on whose land we meet, work and travel > through. We pay our respects to Elders past, present and emerging, and extend > our respect to Aboriginal and Torres Strait Islander people from all Nations > of this land. > > CONFIDENTIALITY AND PRIVILEGE NOTICE > This email is intended only to be read or used by the addressee. It is > confidential and may contain privileged information. If you are not the > intended recipient, any use, distribution, disclosure or copying of this > email is strictly prohibited. Confidentiality and legal privilege attached to > this communication are not waived or lost by reason of the mistaken delivery > to you. If you have received this email in error, please delete it and notify > us immediately by telephone or email. > _______________________________________________ > Oiio-dev mailing list > Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> -- Larry Gritz l...@larrygritz.com
_______________________________________________ Oiio-dev mailing list Oiio-dev@lists.openimageio.org http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
