That's right, to achieve symbol hiding by default, I would replace
"CXX_VISIBILITY_PRESET" (target property) by "CMAKE_CXX_VISIBILITY_PRESET"
(property's default value). That's what I do here anyway to build OIIO.
You've probably already worked it out but, keep in mind that such a change
means that the resulting binary will technically have a different ABI than
previous builds, as symbols have been removed (although they shouldn't be
depended on). Perhaps a change to keep for next ABI changing release?
________________________________
From: Oiio-dev <oiio-dev-boun...@lists.openimageio.org> on behalf of
oiio-dev-requ...@lists.openimageio.org <oiio-dev-requ...@lists.openimageio.org>
Sent: 08 May 2023 15:26
To: oiio-dev@lists.openimageio.org <oiio-dev@lists.openimageio.org>
Subject: Oiio-dev Digest, Vol 176, Issue 5
CAUTION: This email originated from outside of Animal Logic.
Send Oiio-dev mailing list submissions to
oiio-dev@lists.openimageio.org
To subscribe or unsubscribe via the World Wide Web, visit
https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
or, via email, send a message with subject or body 'help' to
oiio-dev-requ...@lists.openimageio.org
You can reach the person managing the list at
oiio-dev-ow...@lists.openimageio.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Oiio-dev digest..."
Today's Topics:
1. Re: Default symbols visibility (linux) (Larry Gritz)
2. Re: fmt-9.1.0 (header only) and gcc lesser than 7.3 (Larry Gritz)
----------------------------------------------------------------------
Message: 1
Date: Sun, 7 May 2023 22:21:38 -0700
From: Larry Gritz <l...@larrygritz.com>
To: OpenImageIO dev list <oiio-dev@lists.openimageio.org>
Subject: Re: [Oiio-dev] Default symbols visibility (linux)
Message-ID: <6ca5180e-da2c-4064-941c-7aa6fa42d...@larrygritz.com>
Content-Type: text/plain; charset="us-ascii"
Oh, I see, so CXX_VISIBILITY_PRESET is the name of the property that can be set
on a target, but CMAKE_CXX_VISIBILITY_PRESET should be the name of the
variable/option if we wish cmake to honor it by adding the property correctly
everywhere?
Is that right? So the solution is to change the name of the cache variable?
> On May 7, 2023, at 10:06 PM, Fabrice Macagno <fabrice.maca...@al.com.au>
> wrote:
>
> Hi there,
> I wanted to double check with you if the intention behind this statement
> <https://clicktime.symantec.com/15tpdUgKk9FjAb9FYE8vG?h=m0i3j-60ZHFtxzIal5mCoSV5tOsBLjcWIz0WMMD9lfQ=&u=https://github.com/OpenImageIO/oiio/blob/32a361ab3ed6479725f0b22d591a436728cfe640/src/cmake/compiler.cmake%23L124>
> is to expose only the symbols which have been explicitly flagged as public?
> I'm asking because, on linux at least, this is not the outcome.
> I use the CMAKE_CXX_VISIBILITY_PRESET
> <https://clicktime.symantec.com/15tpYeV3HXa8keKKzfjme?h=tBJ2F_gzLtaOQ16FACDwogps6BCUgqVr7QzY1ybS0EU=&u=https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_VISIBILITY_PRESET.html%23variable:CMAKE_%253CLANG%253E_VISIBILITY_PRESET>
> instead to achieve this behaviour.
> --
> Fabrice Macagno (He/Him)
> Technical Lead
>
> T: +61 2 9383 4800 (main)
> D: +61 2 8063 2951 (direct)
> E: fabrice.maca...@al.com.au <mailto:fabrice.maca...@al.com.au>
>
> Building 54, 38 Driver Ave
> Moore Park, NSW 2021
> AUSTRALIA
>
>
> <https://clicktime.symantec.com/15tq8Tr2VqMHeG6noaXoz?h=PyNDx2GGjGD0_npupG1oaqPauHxrcsb3WEeLlpzJj4U=&u=https://www.linkedin.com/company/animal-logic>
>
> <https://clicktime.symantec.com/15tpxoTTabz6pNSwiTjWk?h=_dy48Aw9nLgjEbAwoCLlLTYyUqcwD5kJgoquemMtbMc=&u=https://www.facebook.com/Animal-Logic-129284263808191/>
>
> <https://clicktime.symantec.com/15tpsyGB7zJWQRd2AuLN8?h=4A3zF6cwt3m2DsFfaYuxXQsicXIWprE30Mj7aeGIdW8=&u=https://twitter.com/AnimalLogic>
>
> <https://clicktime.symantec.com/15tq3dek3DfhEKGsG28fN?h=D-yUmj7qEtfXc0ybSOx4URZSpurO4LYIZlZYXqBadL4=&u=https://www.instagram.com/animallogicstudios/>
>
>
> <https://clicktime.symantec.com/15tpTpHkputYLhVQT7Ld2?h=6ikMgqQAm0LhyprO9KQIdmuTjcDQVnKhUoXhO5VF3kg=&u=http://www.animallogic.com/>
>
> Animal Logic acknowledges the Traditional Custodians, the Bidjigal people and
> Gadigal people of the Eora Nation, on whose land we meet, work and travel
> through. We pay our respects to Elders past, present and emerging, and extend
> our respect to Aboriginal and Torres Strait Islander people from all Nations
> of this land.
>
> CONFIDENTIALITY AND PRIVILEGE NOTICE
> This email is intended only to be read or used by the addressee. It is
> confidential and may contain privileged information. If you are not the
> intended recipient, any use, distribution, disclosure or copying of this
> email is strictly prohibited. Confidentiality and legal privilege attached to
> this communication are not waived or lost by reason of the mistaken delivery
> to you. If you have received this email in error, please delete it and notify
> us immediately by telephone or email.
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
> https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
> <https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
--
Larry Gritz
l...@larrygritz.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://clicktime.symantec.com/15tpJ9uBugXMWoqZMzYKn?h=-2D1tNvPUx8l_bgWqtbilKi1iQh6OT36QRcsHAvYH0M=&u=http://lists.openimageio.org/pipermail/oiio-dev-openimageio.org/attachments/20230507/8badc895/attachment-0001.htm>
------------------------------
Message: 2
Date: Sun, 7 May 2023 22:26:31 -0700
From: Larry Gritz <l...@larrygritz.com>
To: OpenImageIO dev list <oiio-dev@lists.openimageio.org>
Subject: Re: [Oiio-dev] fmt-9.1.0 (header only) and gcc lesser than
7.3
Message-ID: <1ca8948a-1eb2-4edb-a553-906070157...@larrygritz.com>
Content-Type: text/plain; charset="utf-8"
Ah, interesting. So that sounds like we should downgrade the version of fmt
that is automatically downloaded when none is found locally -- currently 9.1,
but we should use something older to ensure it can compile with all the gcc
versions we claim to support.
And maybe we also should double check and warn if the fmt it found is not going
to work with the gcc being used?
Do you think those two changes would adequately address the problem?
> On May 7, 2023, at 9:54 PM, Fabrice Macagno <fabrice.maca...@al.com.au> wrote:
>
> Hi there, this is more an FYI: fmt-9.1.0
> <https://clicktime.symantec.com/15tpiJscCkwKaXyB5nY4t?h=gR4uZowK-S_o1W8VgN8CGc_1mYp4R5wZzTmZqLf0DVY=&u=https://github.com/OpenImageIO/oiio/blob/32a361ab3ed6479725f0b22d591a436728cfe640/src/cmake/externalpackages.cmake%23L322>
> cannot be built with gcc lesser than 7.3. The issue was fixed
> <https://clicktime.symantec.com/15tpo94tfNcuzUo6dLwDW?h=DxIPZNxwcJBFYjm3uKq2csFMNRWnj2gF2Z7C0yoAYBY=&u=https://github.com/fmtlib/fmt/pull/3066>
> not long after 9.1.0 release.
>
> Knowing this could hopefully save some time for those, like us, who haven't
> moved yet to gcc-9.3 (we're on it though ?)
>
> There are several ways to configure OIIO's build to work around the problem.
> Also, clang builds are fine.
> --
> Fabrice Macagno (He/Him)
> Technical Lead
>
> T: +61 2 9383 4800 (main)
> D: +61 2 8063 2951 (direct)
> E: fabrice.maca...@al.com.au <mailto:fabrice.maca...@al.com.au>
>
> Building 54, 38 Driver Ave
> Moore Park, NSW 2021
> AUSTRALIA
>
>
> <https://clicktime.symantec.com/15tq8Tr2VqMHeG6noaXoz?h=PyNDx2GGjGD0_npupG1oaqPauHxrcsb3WEeLlpzJj4U=&u=https://www.linkedin.com/company/animal-logic>
>
> <https://clicktime.symantec.com/15tpxoTTabz6pNSwiTjWk?h=_dy48Aw9nLgjEbAwoCLlLTYyUqcwD5kJgoquemMtbMc=&u=https://www.facebook.com/Animal-Logic-129284263808191/>
>
> <https://clicktime.symantec.com/15tpsyGB7zJWQRd2AuLN8?h=4A3zF6cwt3m2DsFfaYuxXQsicXIWprE30Mj7aeGIdW8=&u=https://twitter.com/AnimalLogic>
>
> <https://clicktime.symantec.com/15tq3dek3DfhEKGsG28fN?h=D-yUmj7qEtfXc0ybSOx4URZSpurO4LYIZlZYXqBadL4=&u=https://www.instagram.com/animallogicstudios/>
>
>
> <https://clicktime.symantec.com/15tpTpHkputYLhVQT7Ld2?h=6ikMgqQAm0LhyprO9KQIdmuTjcDQVnKhUoXhO5VF3kg=&u=http://www.animallogic.com/>
>
> Animal Logic acknowledges the Traditional Custodians, the Bidjigal people and
> Gadigal people of the Eora Nation, on whose land we meet, work and travel
> through. We pay our respects to Elders past, present and emerging, and extend
> our respect to Aboriginal and Torres Strait Islander people from all Nations
> of this land.
>
> CONFIDENTIALITY AND PRIVILEGE NOTICE
> This email is intended only to be read or used by the addressee. It is
> confidential and may contain privileged information. If you are not the
> intended recipient, any use, distribution, disclosure or copying of this
> email is strictly prohibited. Confidentiality and legal privilege attached to
> this communication are not waived or lost by reason of the mistaken delivery
> to you. If you have received this email in error, please delete it and notify
> us immediately by telephone or email.
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org <mailto:Oiio-dev@lists.openimageio.org>
> https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
>
> <https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org>
--
Larry Gritz
l...@larrygritz.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://clicktime.symantec.com/15tpNz6UNJCwvkfUuYwUQ?h=vmaVPhuTIsj0-i7TC9_BmyRfatD8zIrmU7trWwhFcT8=&u=http://lists.openimageio.org/pipermail/oiio-dev-openimageio.org/attachments/20230507/92dc8cc3/attachment.htm>
------------------------------
Subject: Digest Footer
_______________________________________________
Oiio-dev mailing list
Oiio-dev@lists.openimageio.org
https://clicktime.symantec.com/15tpDKhuT4qm6s1dpS9BA?h=wpk78kzIQ5lOS4Jp-EuVXjOehpFexKfyMU2WzvDLLBM=&u=http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
------------------------------
End of Oiio-dev Digest, Vol 176, Issue 5
****************************************
_______________________________________________
Oiio-dev mailing list
Oiio-dev@lists.openimageio.org
http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
