Just a guess, but if there was a test case, the change would get committed pretty 
quick (probably within an hour or two).

Changes without test cases take longer.
 
m

        -----Original Message----- 
        From: Jens Krämer [mailto:kraemer@;webit.de] 
        Sent: Thu 10/17/2002 6:41 AM 
        To: OJB Users List 
        Cc: 
        Subject: Re: Bug in PersistenceBrokerImpl.java
        
        

        On Tue, Oct 15, 2002 at 11:30:59AM +0200, Rudi Alberda wrote:
        > Hi All
        >
        > Some time ago I mailed some problems I had using proxy m:n collections in
        > combination with other proxy m:n collection objects; Setting one seemed to
        > clear the other (which is clearly not what we want). I traced the problem
        > back to what I think is a bug in PersistenceBrokerImpl.java; what happens is
        > that every time an object is stored and the reference collections are stored
        > as well, the entries in the indirection table are deleted and later added
        > again, _except_ when the collection is proxy and not loaded yet. Which means
        > the loss of reference collections. I switched the two checks which solves
        > the bug for me; below is the code I switched around.
        >
        >    // MBAIRD
        >    // if the collection is a collectionproxy and it's not already loaded
        >    // no need to store it.
        >    if (col instanceof CollectionProxy && !((CollectionProxy)col).isLoaded())
        >    {
        >     continue;
        >    }
        >
        >         if (cds.isMtoNRelation())
        >         {
        >             /* LEANDRO
        >              * Clear all MtoN implementors.
        >              * All new MtoN implementors are going to be added bellow
        >              */
        >             //logger.info("STORE COLLECTIONS: deleting all MtoN implementors
        > for field "+cds.getPersistentField().getName());
        >             deleteMtoNImplementor(cds, obj);
        >         }
        >
        
        
        I think I understand the problem and I wonder why this fix hasn't been
        integrated into CVS yet ?
        
        Greetings,
        Jens
        
        --
        Jens Krämer
        [EMAIL PROTECTED]
        
        --
        To unsubscribe, e-mail:   <mailto:ojb-user-unsubscribe@;jakarta.apache.org>
        For additional commands, e-mail: <mailto:ojb-user-help@;jakarta.apache.org>
        
        

<<winmail.dat>>

--
To unsubscribe, e-mail:   <mailto:ojb-user-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:ojb-user-help@;jakarta.apache.org>


Reply via email to