-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
-----------------------------------------------------------
I'd say we're still leaking m_currentTransition sometimes, like for example
PresentationWidget::slotPrevPage has
if ( m_transitionTimer->isActive() )
{
m_transitionTimer->stop();
update();
}
so the transition step won't be called and m_currentTransition won't be
deleted. Isn't it easier if you just make it a member variable instead of a
pointer so we don't have to worry about it?
- Albert Astals Cid
On jun. 20, 2014, 5:06 a.m., Saheb Preet Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
>
> (Updated jun. 20, 2014, 5:06 a.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 317073
> http://bugs.kde.org/show_bug.cgi?id=317073
>
>
> Repository: okular
>
>
> Description
> -------
>
> implemented fade in and fade out transition for presentation mode in okular.
>
>
> Diffs
> -----
>
> conf/dlgpresentationbase.ui 31db693
> conf/okular.kcfg f980989
> ui/presentationwidget.h a99b8ce
> ui/presentationwidget.cpp 4aaec2a
>
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
>
>
> Testing
> -------
>
> It works fine on my system accept for the first time in case of fade out
> transition.
>
>
> Thanks,
>
> Saheb Preet Singh
>
>
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
