----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/#review67595 -----------------------------------------------------------
ui/presentationwidget.cpp <https://git.reviewboard.kde.org/r/115532/#comment47119> Two things, can we find a better name for m_lastRenderedPixmapCopy ? As far as i understand is the "original" version we later restore when the animation has finished. Maybe m_lastRenderedPixmapOriginal? Also I was wondering if we can redude the copying to when we really need it? Can we maybe just do this inside initTransition? - Albert Astals Cid On set. 22, 2014, 8:30 a.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115532/ > ----------------------------------------------------------- > > (Updated set. 22, 2014, 8:30 a.m.) > > > Review request for Okular. > > > Bugs: 317073 > http://bugs.kde.org/show_bug.cgi?id=317073 > > > Repository: okular > > > Description > ------- > > implemented fade in and fade out transition for presentation mode in okular. > > > Diffs > ----- > > conf/dlgpresentationbase.ui 31db693 > conf/okular.kcfg f980989 > ui/presentationwidget.h a99b8ce > ui/presentationwidget.cpp 4aaec2a > > Diff: https://git.reviewboard.kde.org/r/115532/diff/ > > > Testing > ------- > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
