> On Oct. 31, 2015, 7:28 a.m., Saheb Preet Singh wrote: > > Hi, > > > > I tried your patch it works fine. > > > > But when I try increasing the border width to high values, it covers the > > text inside inline note. It would look nice if text is adjusted according > > to borders.
Hello, Thanks for pointing that out. To test quickly, I was using only blank annotations. I'll try and see if I can do something about it. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125801/#review87771 ----------------------------------------------------------- On Oct. 29, 2015, 3:39 p.m., Sumit Sahrawat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125801/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 3:39 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 332887 > http://bugs.kde.org/show_bug.cgi?id=332887 > > > Repository: okular > > > Description > ------- > > Make inline annotation border width customizable, using a spin widget to > accept input > > > Diffs > ----- > > conf/widgetannottools.cpp 6d05eed > ui/annotationwidgets.h 6e7a218 > ui/annotationwidgets.cpp 450e50b > ui/pagepainter.cpp 6eed5b6 > > Diff: https://git.reviewboard.kde.org/r/125801/diff/ > > > Testing > ------- > > Saved a document with various widths for border from 0 to more. > > Opened it in okular itself, and it worked. > The unpatched version of okular also works fine, and uses the same width as > set using the patched version. > > Other pdf readers on linux (`evince`, `zathura`, `acroread-9.5.5`), do not > display any annotations. No matter which okular (patched or unpatched) is > used to create them. > > > Thanks, > > Sumit Sahrawat > >
_______________________________________________ Okular-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/okular-devel
