-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125801/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 11:15 p.m.)
Review request for Okular and Albert Astals Cid.
Changes
-------
Some small tweaks. At this stage, both pdfs and non-pdfs have nearly the same
annotation experience, including the text wrapping and extra padding around the
contents.
I think it will be simpler to leave resizing for bug #177778, as automated
resizing might not work out well for the user anyway.
The only issue that I've been unable to fix is the saving of annotation
settings from `Configure Okular -> Annotations`. This is where I'm currently
stuck.
Bugs: 332887
http://bugs.kde.org/show_bug.cgi?id=332887
Repository: okular
Description
-------
Make inline annotation border width customizable, using a spin widget to accept
input
Diffs (updated)
-----
conf/widgetannottools.cpp 6d05eed
ui/annotationwidgets.h 6e7a218
ui/annotationwidgets.cpp 450e50b
ui/pagepainter.cpp 6eed5b6
Diff: https://git.reviewboard.kde.org/r/125801/diff/
Testing
-------
Saved a document with various widths for border from 0 to more.
Opened it in okular itself, and it worked.
The unpatched version of okular also works fine, and uses the same width as set
using the patched version.
Other pdf readers on linux (`evince`, `zathura`, `acroread-9.5.5`), do not
display any annotations. No matter which okular (patched or unpatched) is used
to create them.
Thanks,
Sumit Sahrawat
_______________________________________________
Okular-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/okular-devel
