michaelweghorn updated this revision to Diff 34821.
michaelweghorn retitled this revision from "PDF: Allow to ignore print margins"
to "Add option to ignore print margins".
michaelweghorn edited the summary of this revision.
michaelweghorn edited the test plan for this revision.
michaelweghorn added a comment.
Changes to previous version:
1. take over Albert's suggestion to make option available to all generators
"as is" (except for fixing a minor typo in a comment ("cad" -> "can") (A big
thanks to Albert!)
2. rename dialog option from "Fit to printable area" to "Ignore printer
margins" and adapt variable names etc. accordingly
3. rebase onto current git master
4. Fix issue that hardware printer margins were still taken into account when
option was set not to do so.
Detail on 4): Further testing with more real printers showed that just passing
the option "fit-to-page" to CUPS without explicitly setting any margins causes
the defaults from the PPD to be used, which is not what is excpected.
This is fixed now by explicitly passing '0'.
(Side note: I missed this at first, since values for the margins in the Qt
print
dialog currently don't seem to be initialized with the PPD default values.)
@aacid: What's the right way to properly indicate that an important part of
this
was actually done by you (add you in the copyright, mention in the commit
message,...)?
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10974?vs=29095&id=34821
BRANCH
michaelweghorn/WIP_update_D10974
REVISION DETAIL
https://phabricator.kde.org/D10974
AFFECTED FILES
CMakeLists.txt
core/document.cpp
core/document.h
core/fileprinter.cpp
core/printoptionswidget.cpp
core/printoptionswidget.h
generators/poppler/generator_pdf.cpp
generators/poppler/generator_pdf.h
interfaces/printinterface.h
part.cpp
To: michaelweghorn, #okular
Cc: okular-devel, aacid, ngraham
