tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision.
REVISION SUMMARY This is mainly preparation for upcoming typewriter tests - QApplication::activeModalWidget is the simplest way to lookup a modal QInputDialog. In consequence, Okular::Part *p is no longer required. - QMetaObject::invokeMethod(button, "click", Qt::QueuedConnection) is required to avoid crashes, when CloseDialogHelper is used for QInputDialog from PickPointEngine::addTextNote. The latter is probably a workaround for a hidden bug in Okulars PickPointEngine::addTextNote. Try this: Fire up okular in KDABs gammaray, select inline note tool, and click into a page. Now 20..50 QInputDialogs pop up immediately, instead of 1. That's basically the same as what we encountered in the test prior using invokeMethod. Depends on D15205 <https://phabricator.kde.org/D15205> (well, not really, but I think it's best to present this revision as part of patch series). TEST PLAN - tests in parttest continue to work as they did before REPOSITORY R223 Okular BRANCH typewriter_test1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15347 AFFECTED FILES autotests/parttest.cpp To: tobiasdeiminger Cc: okular-devel, ngraham, aacid
