simgunz added a comment.
Using the QFormLayout simplified the code a quite a bit! Regarding the stamp annotation tool, I have aligned the combobox to the top, because I have not found a way to vertically align the label. Though I will soon open a new review with some changes for that annotation tool in particular, where I plan to move the preview beneath the combobox. (or maybe I can do it directly in this review?) F6857731: Screenshot_20190529_095154.png <https://phabricator.kde.org/F6857731> INLINE COMMENTS > annotationwidgets.cpp:206 > + formlayout->setLabelAlignment( Qt::AlignRight ); > + formlayout->setFieldGrowthPolicy( QFormLayout::AllNonFixedFieldsGrow ); > if ( hasColorButton() ) Is it correct to set this growth policy? I have not found any guideline on the HIG. Compared to the grid layout where label and widget take the same amount of horizontal space, now the widgets take way more space making it a little ugly for some annotation tools. Any idea? F6857727: Screenshot_20190529_095013.png <https://phabricator.kde.org/F6857727> REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
