davidhurka added a comment.

  In D10859#471799 <https://phabricator.kde.org/D10859#471799>, @ngraham wrote:
  
  > I don't think the section headings really added much. Most of them were 
group boxes with one item, which is pointless. When using a FormLayout style,  
in general you want to make the labels self-explanatory as much as possible so 
you don't need section headers. To separate groups of related settings, you can 
add some whitespace that has the effect of grouping things together in a very 
natural-looking way. We do this extensively in other FormLayouts and people 
generally think it looks good:
  
  
  I’m not sure whether to agree.
  
  Your screenshots show vertical whitespace, but between differently shaped 
widgets. That makes the space appear a bit random. Then I looked in System 
Settings, which uses mostly group boxes, and sometimes space, section labels, 
and horizontal lines.
  
  But in this dialog, whitespace will probably look good, because all widgets 
have the same shape.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10859

To: simgunz, #okular, #vdg, ngraham
Cc: davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, 
darcyshen

Reply via email to