simgunz updated this revision to Diff 59017. simgunz added a comment.
Still very rough, but most of the tools and corresponding basic settings are now there. Remember to move/remove ~/.config/okularpartrc before testing this. Changes highlights: - Check if chosen color is valid before storing it - Notify PageViewAnnotator when the color has changed - Add typewriter annotation tool - Save annotation tool settings to file on exit - Add font selector - Add basic implementation of width selector - Remove delay from toolbar popups - Enable config actions based on selected annotation - Add arrow annotation - Add inner color selector - Set inner color icon to transparent if tool does not support it - Allow setting font color - Fix crash on application exit - Improve annotations default colors REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=42831&id=59017 BRANCH annotation-toolbar-stable REVISION DETAIL https://phabricator.kde.org/D15580 AFFECTED FILES part.rc ui/data/tools.xml ui/pageview.cpp ui/pageviewannotator.cpp ui/pageviewannotator.h ui/pageviewutils.cpp ui/pageviewutils.h ui/toolaction.cpp To: simgunz, #okular Cc: knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
