Michael, Sorry to bother you.
Could you please merge the below gerrit request? https://gerrit.onap.org/r/#/c/19033/ -----Original Message----- From: Murali p Sent: 24 October 2017 12:02 To: Michael Lando <[email protected]> Cc: Ilana Paktor <[email protected]> Subject: FW: [onap][sdc] Integrate VNF Repository with SDC Michael, Do you have any concerns with below changes? Please approve so that Ilana can merge the changes to gerrit. With regards, Murali -----Original Message----- From: Murali p Sent: 23 October 2017 18:36 To: Lando,Michael <[email protected]>; Ilana Paktor <[email protected]>; Lema Rayapati <[email protected]>; Shahid Noor <[email protected]> Cc: 'Halfon Tal' <[email protected]> Subject: [onap][sdc] Integrate VNF Repository with SDC Michael, Please check and approve the below two changes. 1. VNFSDK Repo do not support https as now (Will plan to support in Release-2) 2. The port is fixed (VNFSDK Repo) and the IP address can be configured. -----Original Message----- From: Ilana Paktor (ONAP Code Review) [mailto:[email protected]] Sent: 23 October 2017 18:02 To: Murali p <[email protected]> Cc: Michael Lando <[email protected]>; Tal Halfon <[email protected]>; Einav Keidar <[email protected]>; ONAP Jobbuilder <[email protected]> Subject: Change in sdc[release-1.1.0]: Integrate VNF Repository with SDC Ilana Paktor has posted comments on this change. Change subject: Integrate VNF Repository with SDC ...................................................................... Patch Set 5: (2 comments) Michael, please approve the hardcoded port and protocol. http://gerrit.onap.org/r/#/c/19033/5/openecomp-ui/src/sdc-app/config/config.json File openecomp-ui/src/sdc-app/config/config.json: PS5, Line 8: :8702 hardcoded port http://gerrit.onap.org/r/#/c/19033/5/openecomp-ui/src/sdc-app/onboarding/softwareProduct/vnfMarketPlace/VNFImportActionHelper.js File openecomp-ui/src/sdc-app/onboarding/softwareProduct/vnfMarketPlace/VNFImportActionHelper.js: PS5, Line 27: http:// hardcoded protocol -- To view, visit http://gerrit.onap.org/r/19033 To unsubscribe, visit http://gerrit.onap.org/r/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c721829efdac8ad6f72c4ac9d25ec96e091f7ca Gerrit-PatchSet: 5 Gerrit-Project: sdc Gerrit-Branch: release-1.1.0 Gerrit-Owner: Murali Mohan Murthy Potham <[email protected]> Gerrit-Reviewer: Einav Keidar <[email protected]> Gerrit-Reviewer: Ilana Paktor <[email protected]> Gerrit-Reviewer: Michael Lando <[email protected]> Gerrit-Reviewer: ONAP Jobbuilder <[email protected]> Gerrit-Reviewer: Tal Halfon <[email protected]> Gerrit-HasComments: Yes _______________________________________________ onap-discuss mailing list [email protected] https://lists.onap.org/mailman/listinfo/onap-discuss
