Hi, As we discussed we have an issue with the hard coded url and port. This should be configurable and done from the be server.
BR, Michael Lando Opensource TL , SDC AT&T Network Application Development · NetCom Tel Aviv | Tampa | Atlanta | New Jersey |Chicago ··········································································· Office: +972 (3) 5451487 Mobile: +972 (54) 7833603 e-mail: [email protected] -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Murali p Sent: Tuesday, October 24, 2017 4:47 PM To: [email protected] Subject: [onap-discuss] [onap][sdc] Integrate VNF Repository with SDC Michael, Sorry to bother you. Could you please merge the below gerrit request? https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.onap.org_r_-23_c_19033_&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=_bS-r26G67qXyWNdVU7d_MRXrEcJrxEyzvX3ENGsLIA&e= -----Original Message----- From: Murali p Sent: 24 October 2017 12:02 To: Michael Lando <[email protected]> Cc: Ilana Paktor <[email protected]> Subject: FW: [onap][sdc] Integrate VNF Repository with SDC Michael, Do you have any concerns with below changes? Please approve so that Ilana can merge the changes to gerrit. With regards, Murali -----Original Message----- From: Murali p Sent: 23 October 2017 18:36 To: Lando,Michael <[email protected]>; Ilana Paktor <[email protected]>; Lema Rayapati <[email protected]>; Shahid Noor <[email protected]> Cc: 'Halfon Tal' <[email protected]> Subject: [onap][sdc] Integrate VNF Repository with SDC Michael, Please check and approve the below two changes. 1. VNFSDK Repo do not support https as now (Will plan to support in Release-2) 2. The port is fixed (VNFSDK Repo) and the IP address can be configured. -----Original Message----- From: Ilana Paktor (ONAP Code Review) [mailto:[email protected]] Sent: 23 October 2017 18:02 To: Murali p <[email protected]> Cc: Michael Lando <[email protected]>; Tal Halfon <[email protected]>; Einav Keidar <[email protected]>; ONAP Jobbuilder <[email protected]> Subject: Change in sdc[release-1.1.0]: Integrate VNF Repository with SDC Ilana Paktor has posted comments on this change. Change subject: Integrate VNF Repository with SDC ...................................................................... Patch Set 5: (2 comments) Michael, please approve the hardcoded port and protocol. https://urldefense.proofpoint.com/v2/url?u=http-3A__gerrit.onap.org_r_-23_c_19033_5_openecomp-2Dui_src_sdc-2Dapp_config_config.json&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=IqsbhAT5zitDYUz0WcI4Zp3ISrAf6mLWnee_gqXgHpY&e= File openecomp-ui/src/sdc-app/config/config.json: PS5, Line 8: :8702 hardcoded port https://urldefense.proofpoint.com/v2/url?u=http-3A__gerrit.onap.org_r_-23_c_19033_5_openecomp-2Dui_src_sdc-2Dapp_onboarding_softwareProduct_vnfMarketPlace_VNFImportActionHelper.js&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=m56p7atw79LBSicTcVY1SIO0QuXe6oVog4Ozi4cY2dE&e= File openecomp-ui/src/sdc-app/onboarding/softwareProduct/vnfMarketPlace/VNFImportActionHelper.js: PS5, Line 27: http:// hardcoded protocol -- To view, visit https://urldefense.proofpoint.com/v2/url?u=http-3A__gerrit.onap.org_r_19033&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=JQmyyImaUZZYDbncSSPLC9UkVbHylrA6pI6dozajMrE&e= To unsubscribe, visit https://urldefense.proofpoint.com/v2/url?u=http-3A__gerrit.onap.org_r_settings&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=uf_Ng6MBRN-Wa9Eqoo9T8wawOJlg2TT70K9UIiTpBY0&e= Gerrit-MessageType: comment Gerrit-Change-Id: I0c721829efdac8ad6f72c4ac9d25ec96e091f7ca Gerrit-PatchSet: 5 Gerrit-Project: sdc Gerrit-Branch: release-1.1.0 Gerrit-Owner: Murali Mohan Murthy Potham <[email protected]> Gerrit-Reviewer: Einav Keidar <[email protected]> Gerrit-Reviewer: Ilana Paktor <[email protected]> Gerrit-Reviewer: Michael Lando <[email protected]> Gerrit-Reviewer: ONAP Jobbuilder <[email protected]> Gerrit-Reviewer: Tal Halfon <[email protected]> Gerrit-HasComments: Yes _______________________________________________ onap-discuss mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.onap.org_mailman_listinfo_onap-2Ddiscuss&d=DwICAg&c=LFYZ-o9_HUMeMTSQicvjIg&r=FYvXSElfSmWIXOeZxWIxQysejuz9-TXmaL6uftBh8MY&m=Uos4suMutK_wGE-rgZV598-OUCTGDhQCg_97fhuJlvA&s=Xth0VCtB4kV6-gmdG3-hLveMU3GWZZFTpZbhXiR5Zi0&e= _______________________________________________ onap-discuss mailing list [email protected] https://lists.onap.org/mailman/listinfo/onap-discuss
