That’s a good solution Brian, not that we haven’t thought about it. We’re looking into un-forking every config bit we forked to integrate the fork we’ve done correctly in each project.
ONAP has 80+ containers, hence we forked config at first, but there is a long journey in front of us to un-fork things, and it’s not always as strait-forward as in this case. Moreover, it implies ppl are willing to accept update to their config to satisfy OOM needs. In R1 we were told OOM isn’t the default deploy solution, so our updates were discarded. Now Amsterdam is out, ppl are getting more aware of the mechanic of OOM. because it’s getting better. So Maybe now is a good time to fix things. But the issue is slightly bigger than this. Basically, we should centralized configuration and derived properties of properties files from there. This way, we update only one place, and everybody is happy. But that’s another battle for another time. Long story short, fork was easier for us to get where we are, but we always knew this was not a permanent solution: see OOM-10 <https://jira.onap.org/browse/OOM-10> Alexis > On Jan 11, 2018, at 4:39 PM, FREEMAN, BRIAN D <[email protected]> wrote: > > So why not submit a change to testsuite so they split it into two IP’s and > modify the robot_vm_install.sh to ocpy the input into the two variable so > that we can use the same asdc_interface.robot for either HEAT or OOM ? > > Testsuite will be adding to the asdc_interface.robot over time (as in this > case) . > > I’m sure you dont want to maintain these files in OOM long term. > > Brian > > > From: Alexis de Talhouët [mailto:[email protected] > <mailto:[email protected]>] > Sent: Thursday, January 11, 2018 4:29 PM > To: FREEMAN, BRIAN D <[email protected] <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]> > Subject: Re: [onap-discuss] OOM Robot Distribute > > It’s the same IP address in the HEAT deployment. In OOM it’s not the same. > > sdc-fe.onap-sdc for frontend —> GLOBAL_INJECTED_SDC_FE_IP_ADDR > sdc-be.onap-sdc for backend —> GLOBAL_INJECTED_SDC_BE_IP_ADDR > > Alexis > > > On Jan 11, 2018, at 4:07 PM, FREEMAN, BRIAN D <[email protected] > <mailto:[email protected]>> wrote: > > The front end and back of SDC are the same IP address so its not clear to me > why you had to change anything in the asdc_interface.robot ? > > Brian > > > root@onapoom3:/dockerdata-nfs/onap/robot/robot/resources# diff > asdc_interface.robot asdc_interface.robot.old > 47,48c47,48 > < ${ASDC_FE_ENDPOINT} > ${GLOBAL_ASDC_SERVER_PROTOCOL}://${GLOBAL_INJECTED_SDC_IP_ADDR}:${GLOBAL_ASDC_FE_PORT} > < ${ASDC_BE_ENDPOINT} > ${GLOBAL_ASDC_SERVER_PROTOCOL}://${GLOBAL_INJECTED_SDC_IP_ADDR}:${GLOBAL_ASDC_BE_PORT} > --- > > ${ASDC_FE_ENDPOINT} > > ${GLOBAL_ASDC_SERVER_PROTOCOL}://${GLOBAL_INJECTED_SDC_FE_IP_ADDR}:${GLOBAL_ASDC_FE_PORT} > > ${ASDC_BE_ENDPOINT} > > ${GLOBAL_ASDC_SERVER_PROTOCOL}://${GLOBAL_INJECTED_SDC_BE_IP_ADDR}:${GLOBAL_ASDC_BE_PORT} > 56d55 > < ${catalog_resources}= Create Dictionary > 62d60 > < \ Set To Dictionary ${catalog_resources} > ${loop_catalog_resource_id}=${loop_catalog_resource_resp} > 74,75c72,73 > < [Return] ${catalog_service_resp['name']} > ${loop_catalog_resource_resp['name']} ${vf_module} > ${catalog_resource_ids} ${catalog_service_id} ${catalog_resources} > < > --- > > [Return] ${catalog_service_resp['name']} > > ${loop_catalog_resource_resp['name']} ${vf_module} > > ${catalog_resource_ids} ${catalog_service_id} > > > 297,298c295,296 > < [Documentation] Creates an asdc Software Product and returns its id > < [Arguments] ${software_product_id} ${file_path} > ${version_id}=0.1 > --- > > [Documentation] Creates an asdc Software Product and returns its id > > [Arguments] ${software_product_id} ${file_path} > > ${version_id}=0.1 > 301,302c299,300 > < ${resp}= Run ASDC Post Files Request > ${ASDC_VENDOR_SOFTWARE_PRODUCT_PATH}/${software_product_id}/versions/${version_id}${ASDC_VENDOR_SOFTWARE_UPLOAD_PATH} > ${files} ${ASDC_DESIGNER_USER_ID} > < Should Be Equal As Strings ${resp.status_code} 200 > --- > > ${resp}= Run ASDC Post Files Request > > ${ASDC_VENDOR_SOFTWARE_PRODUCT_PATH}/${software_product_id}/versions/${version_id}${ASDC_VENDOR_SOFTWARE_UPLOAD_PATH} > > ${files} ${ASDC_DESIGNER_USER_ID} > > Should Be Equal As Strings ${resp.status_code} 200 > > From: Alexis de Talhouët [mailto:[email protected] > <mailto:[email protected]>] > Sent: Thursday, January 11, 2018 4:01 PM > To: FREEMAN, BRIAN D <[email protected] <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]> > Subject: Re: [onap-discuss] OOM Robot Distribute > > > > > > On Jan 11, 2018, at 4:00 PM, Alexis de Talhouët <[email protected] > <mailto:[email protected]>> wrote: > > Robot can point to HEAT’s VM IP, whereas robot point to the service directly.. > > Not clear. In the HEAT setup, robot points to the SDC VM IP for that > resources, whereas for the OOM setup, we point directly to the frontend or > backend service.
_______________________________________________ onap-discuss mailing list [email protected] https://lists.onap.org/mailman/listinfo/onap-discuss
