Can open a bug, not sure if we want to reject the request all together or 
simply drop the params.

Thanks

-Steve


From: <[email protected]> on behalf of Alexis de Talhouet 
<[email protected]>
Reply-To: "[email protected]" <[email protected]>, 
"[email protected]" <[email protected]>
Date: Thursday, October 11, 2018 at 5:30 PM
To: onap-discuss <[email protected]>, "[email protected]" 
<[email protected]>
Subject: Re: [onap-discuss] [SO] Create/Activate BB NPE

What I found out is this comment in the code:

https://github.com/onap/so/blob/3d249b7ac314a5cd59e117672d4b678d33e34c7a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflow/tasks/WorkflowAction.java#L242-L245<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_onap_so_blob_3d249b7ac314a5cd59e117672d4b678d33e34c7a_bpmn_so-2Dbpmn-2Dtasks_src_main_java_org_onap_so_bpmn_infrastructure_workflow_tasks_WorkflowAction.java-23L242-2DL245&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=shs6nPzThSiGJml9VXN0Eg&m=6J__P51d0zW-BOdKDnyu7WvEkFLCwlLpbcKTStnSv_E&s=RxFlDUElNUCWoEbDoxBJq_NFbLr_2Nx8lye3uRZ9FWk&e=>

// SERVICE-MACRO-ACTIVATE, SERVICE-MACRO-UNASSIGN, and
// SERVICE-MACRO-DELETE
// Will never get user params with service, macro will have
// to query the SI in AAI to find related instances.

I was passing user param, even though it’s a service macro activate request I’m 
doing… So I’m going through this statement: 
https://github.com/onap/so/blob/049e0e2304a7de75fc0d35aac7319e89715972a9/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetup.java#L887-L895<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_onap_so_blob_049e0e2304a7de75fc0d35aac7319e89715972a9_bpmn_MSOCommonBPMN_src_main_java_org_onap_so_bpmn_servicedecomposition_tasks_BBInputSetup.java-23L887-2DL895&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=shs6nPzThSiGJml9VXN0Eg&m=6J__P51d0zW-BOdKDnyu7WvEkFLCwlLpbcKTStnSv_E&s=jbzrPBXhr43PHacbTtRfUJhtWaKBMFVkoHlVlP06_lk&e=>
 which is the one triggering the NPE…

I don’t know how to fix properly the logic, but it should by-pass checking the 
userparam if it’s a service macro assign request.

By not passing userParams, I was able to pass this issue.

Thanks,
Alexis



On Oct 11, 2018, at 11:43 AM, Alexis de Talhouet 
<[email protected]<mailto:[email protected]>> wrote:

Hello SO team,

After having successfully assigned my service, I’m now activating it.
During that process, I hit an NPE.

Logs and sent request are attached.

Is this a bug, or am I missing something in the request?

Thanks,
Alexis




<SO macro activate - failure - vFW_CDS.txt><request-activate.txt>



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12969): https://lists.onap.org/g/onap-discuss/message/12969
Mute This Topic: https://lists.onap.org/mt/27243130/21656
Group Owner: [email protected]
Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to