Steve,
It may be an issue with the payload request for create and activate.
I’m not expecting the create-activate BB to have the user parameters being
passed from VID b/c all the assignment are completed in previous flow.
Can you confirm if this is a valid payload request.
Request-activate---current
Should Be???
POST
/onap/so/infra/serviceInstantiation/v7/serviceInstances/a644aad7-fbc3-4252-b732-bb2bcc86fde6/activate
HTTP/1.1
Host: 10.195.197.73
Content-Type: application/json
Accept: application/json
X-FromAppId: Postman
X-TransactionId: postman-123
{
"requestDetails": {
"subscriberInfo": {
"globalSubscriberId": "Demonstration"
},
"requestInfo": {
"suppressRollback": true,
"productFamilyId": "a9a77d5a-123e-4ca2-9eb9-0b015d2ee0fb",
"requestorId": "adt",
"instanceName": "test-1234",
"source": "VID"
},
"requestParameters": {
"subscriptionServiceType": "vFW",
"userParams": [
{
"service": {
"instanceParams": [
],
"instanceName": "Service_E2E_vFW",
"resources": {
"vnfs": [
{
"modelInfo": {
"modelName": "d26a74bc-3fdb-4fd2-ad55",
"modelVersionId": "69a7d967-fe68-49d2-ad6b-fc40f5f5b31c",
"modelInvariantUuid":
"c397d40f-cd2a-4b19-add6-e12ea9ecf4ab",
"modelVersion": "2.0",
"modelCustomizationId":
"2cc242bc-ff38-4bac-9650-5fe1b54f5aeb",
"modelInstanceName": "d26a74bc-3fdb-4fd2-ad55 0"
},
"cloudConfiguration": {
"lcpCloudRegionId": "RegionOne",
"tenantId": "demo"
},
"platform": {
"platformName": "test"
},
"lineOfBusiness": {
"lineOfBusinessName": "someValue"
},
"productFamilyId": "a9a77d5a-123e-4ca2-9eb9-0b015d2ee0fb",
"instanceName": "vFirewall 0",
"instanceParams": [
],
"vfModules": [
{
"modelInfo": {
"modelName":
"D26a74bc3fdb4fd2Ad55..base_template..module-0",
"modelVersionId":
"e3c095c3-a620-4828-a689-7132936b90ff",
"modelInvariantUuid":
"ac36a6de-0f92-4ee2-8b39-1b0dba0058f5",
"modelVersion": "1",
"modelCustomizationId":
"1f8ff6cf-640b-432f-9dec-1352b7e1f862"
},
"instanceName":
"vfirewall0..Vfirewall..base_template..module-0",
"instanceParams": [
{
}
]
},
{
"modelInfo": {
"modelName": "D26a74bc3fdb4fd2Ad55..vfw..module-3",
"modelVersionId":
"086223d6-352c-47d3-abb4-213711fc5188",
"modelInvariantUuid":
"d9e4a4e0-c0d3-4bd3-89cc-c6b95af29f6d",
"modelVersion": "1",
"modelCustomizationId":
"a6751179-1762-4771-8ccb-541516c53cf2"
},
"instanceName": "vfirewall0..Vfirewall..vfw..module-0",
"instanceParams": [
{
}
]
},
{
"modelInfo": {
"modelName": "D26a74bc3fdb4fd2Ad55..vpg..module-2",
"modelVersionId":
"6a18492b-4c9d-47a5-a8eb-34b085db0eb0",
"modelInvariantUuid":
"74d0a390-c76f-42fd-ae5d-dc9bea9b79a5",
"modelVersion": "1",
"modelCustomizationId":
"a505c501-0264-4835-821e-006d603691a9"
},
"instanceName": "vfirewall0..Vfirewall..vpg..module-0",
"instanceParams": [
{
}
]
},
{
"modelInfo": {
"modelName": "D26a74bc3fdb4fd2Ad55..vsn..module-1",
"modelVersionId":
"37272aa7-aa29-4772-a1f9-2a67c5860df6",
"modelInvariantUuid":
"ba2e53f1-73ca-40c2-97fe-a1bc74c278ba",
"modelVersion": "1",
"modelCustomizationId":
"8b59f644-f1ac-4a57-8ddb-c6680bc5a22c"
},
"instanceName": "vfirewall0..Vfirewall..vsn..module-0",
"instanceParams": [
{
}
]
}
]
}
]
},
"modelInfo": {
"modelVersion": "1.0",
"modelVersionId": "88da85c-d9e8-4f73-b837-3a72a431622b",
"modelInvariantId": "7242c3f8-c5d8-4069-be3c-0db8bf4caa4d",
"modelName": "vFW_CDS",
"modelType": "service"
}
}
}
],
"aLaCarte": false
},
"project": {
"projectName": "Project-Demonstration"
},
"owningEntity": {
"owningEntityId": "33a8b609-1cfe-4d19-8dc2-5b95b921dd1e",
"owningEntityName": "OE-Demonstration"
},
"modelInfo": {
"modelVersion": "1.0",
"modelVersionId": "88da85c-d9e8-4f73-b837-3a72a431622b",
"modelInvariantId": "7242c3f8-c5d8-4069-be3c-0db8bf4caa4d",
"modelName": "vFW_CDS",
"modelType": "service"
}
}
}
{
"requestDetails": {
"subscriberInfo": {
"globalSubscriberId": "Demonstration"
},
"requestInfo": {
"suppressRollback": true,
"productFamilyId": "a9a77d5a-123e-4ca2-9eb9-0b015d2ee0fb",
"requestorId": "adt",
"instanceName": "test-1234",
"source": "VID"
},
"requestParameters": {
"subscriptionServiceType": "vFW",
"userParams": [
{
"service": {
"instanceParams": [],
"instanceName": "Service_E2E_vFW",
"resources": {},
"modelInfo": {
"modelVersion": "1.0",
"modelVersionId": "88da85c-d9e8-4f73-b837-3a72a431622b",
"modelInvariantId": "7242c3f8-c5d8-4069-be3c-0db8bf4caa4d",
"modelName": "vFW_CDS",
"modelType": "service"
}
}
}
],
"aLaCarte": false
},
"project": {
"projectName": "Project-Demonstration"
},
"owningEntity": {
"owningEntityId": "33a8b609-1cfe-4d19-8dc2-5b95b921dd1e",
"owningEntityName": "OE-Demonstration"
},
"modelInfo": {
"modelVersion": "1.0",
"modelVersionId": "88da85c-d9e8-4f73-b837-3a72a431622b",
"modelInvariantId": "7242c3f8-c5d8-4069-be3c-0db8bf4caa4d",
"modelName": "vFW_CDS",
"modelType": "service"
}
}
}
From: [email protected] [mailto:[email protected]] On
Behalf Of SMOKOWSKI, STEVEN
Sent: Thursday, October 11, 2018 6:14 PM
To: [email protected]; [email protected]
Subject: Re: [onap-discuss] [SO] Create/Activate BB NPE
***Security Advisory: This Message Originated Outside of AT&T ***
Reference http://cso.att.com/EmailSecurity/IDSP.html for more information.
Can open a bug, not sure if we want to reject the request all together or
simply drop the params.
Thanks
-Steve
From: <[email protected]<mailto:[email protected]>> on
behalf of Alexis de Talhouet
<[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>,
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Thursday, October 11, 2018 at 5:30 PM
To: onap-discuss
<[email protected]<mailto:[email protected]>>,
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: [onap-discuss] [SO] Create/Activate BB NPE
What I found out is this comment in the code:
https://github.com/onap/so/blob/3d249b7ac314a5cd59e117672d4b678d33e34c7a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflow/tasks/WorkflowAction.java#L242-L245<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_onap_so_blob_3d249b7ac314a5cd59e117672d4b678d33e34c7a_bpmn_so-2Dbpmn-2Dtasks_src_main_java_org_onap_so_bpmn_infrastructure_workflow_tasks_WorkflowAction.java-23L242-2DL245&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=shs6nPzThSiGJml9VXN0Eg&m=6J__P51d0zW-BOdKDnyu7WvEkFLCwlLpbcKTStnSv_E&s=RxFlDUElNUCWoEbDoxBJq_NFbLr_2Nx8lye3uRZ9FWk&e=>
// SERVICE-MACRO-ACTIVATE, SERVICE-MACRO-UNASSIGN, and
// SERVICE-MACRO-DELETE
// Will never get user params with service, macro will have
// to query the SI in AAI to find related instances.
I was passing user param, even though it’s a service macro activate request I’m
doing… So I’m going through this statement:
https://github.com/onap/so/blob/049e0e2304a7de75fc0d35aac7319e89715972a9/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetup.java#L887-L895<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_onap_so_blob_049e0e2304a7de75fc0d35aac7319e89715972a9_bpmn_MSOCommonBPMN_src_main_java_org_onap_so_bpmn_servicedecomposition_tasks_BBInputSetup.java-23L887-2DL895&d=DwMFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=shs6nPzThSiGJml9VXN0Eg&m=6J__P51d0zW-BOdKDnyu7WvEkFLCwlLpbcKTStnSv_E&s=jbzrPBXhr43PHacbTtRfUJhtWaKBMFVkoHlVlP06_lk&e=>
which is the one triggering the NPE…
I don’t know how to fix properly the logic, but it should by-pass checking the
userparam if it’s a service macro assign request.
By not passing userParams, I was able to pass this issue.
Thanks,
Alexis
On Oct 11, 2018, at 11:43 AM, Alexis de Talhouet
<[email protected]<mailto:[email protected]>> wrote:
Hello SO team,
After having successfully assigned my service, I’m now activating it.
During that process, I hit an NPE.
Logs and sent request are attached.
Is this a bug, or am I missing something in the request?
Thanks,
Alexis
<SO macro activate - failure - vFW_CDS.txt><request-activate.txt>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12970): https://lists.onap.org/g/onap-discuss/message/12970
Mute This Topic: https://lists.onap.org/mt/27243130/21656
Group Owner: [email protected]
Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
