CCSDK and SDNC team, We have recently had a large number (dozens) of reviews submitted to address ‘issues’ identified by Sonar. These issues have all been mostly what I would consider editorial in nature (e.g removing commented out code). While we like to welcome all contributions, we must also recognize that large numbers of changes which contribute no new functionality to the project present a burden to reviewers (e.g. I spent most of yesterday morning reviewing Sonar changes) and have frequently resulted in the past in breaking working code. Also, frequently things that Sonar identifies as “issues” are in fact project conventions (e.g. we have a project convention of calling our trace logger LOG – all caps – which Sonar complains about). I would ask that developers kindly not to submit code changes or open Jira tickets to address Sonar “issues” for the CCSDK or SDNC project. Such changes will no longer be merged.
Please note that we will still gladly accept changes to increase test coverage as reported by Sonar. Thanks! Dan -- Dan Timoney Principal Technical Staff Member AT&T Email : [email protected]<mailto:[email protected]> Office : +1 (732) 420-3226 Mobile : +1 (201) 960-1211 200 S Laurel Ave, Rm E2-2A03 Middletown, NJ 08873 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14903): https://lists.onap.org/g/onap-discuss/message/14903 Mute This Topic: https://lists.onap.org/mt/28986504/21656 Mute #ccsdk: https://lists.onap.org/mk?hashtag=ccsdk&subid=2740164 Mute #sdnc: https://lists.onap.org/mk?hashtag=sdnc&subid=2740164 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
