Same as APPC. I have notified sonar contributors individually few weeks ago. I also asked them if they can do code coverage if possible, since we continue focusing on code coverage for Dublin.
Taka From: onap-discuss@lists.onap.org [mailto:onap-discuss@lists.onap.org] On Behalf Of DRAGOSH, PAM Sent: Thursday, January 10, 2019 6:24 AM To: onap-discuss@lists.onap.org Subject: Re: [onap-discuss] Sonar "fixes" no longer accepted #ccsdk #sdnc ***Security Advisory: This Message Originated Outside of AT&T *** Reference http://cso.att.com/EmailSecurity/IDSP.html for more information. I believe that the Policy team is also going to take this stance. We have done a significant amount of work to clean these up, with M1 looming next week our focus is on new code/features. That being said, the team requires our incoming code contributions to fix any newly introduced checkstyle/sonar issues that get identified immediately by the owner of that contribution. One line changes are just too time consuming for the committers to address. Thanks, Pam Dragosh ONAP Policy Framework PTL From: <onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>> on behalf of seshu kumar m <seshu.kuma...@huawei.com<mailto:seshu.kuma...@huawei.com>> Reply-To: "onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>" <onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>>, "seshu.kuma...@huawei.com<mailto:seshu.kuma...@huawei.com>" <seshu.kuma...@huawei.com<mailto:seshu.kuma...@huawei.com>> Date: Thursday, January 10, 2019 at 6:33 AM To: "onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>" <onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org>>, "TIMONEY, DAN" <dt5...@att.com<mailto:dt5...@att.com>> Subject: Re: [onap-discuss] Sonar "fixes" no longer accepted #ccsdk #sdnc I Second the thoughts of Dan on this. It’s a welcome for everyone to participate in the code improvement and make ONAP a better place. But it cannot be on the cost of the actual project execution. To add the troubles shared by Dan, currently, we have tons of Jira issues being created for Sonar alone and its really tough for making a sprint plan filtering them for finding the important ones. It’s a humble request for the guys contributing to kindly come to the weekly meetings and discuss over the strategy and then provide the improvements, at least that would help us to synchronize the energies and efforts. Thanks and Regards, M Seshu Kumar Senior System Architect Single OSS India Branch Department. S/W BU. Huawei Technologies India Pvt. Ltd. Survey No. 37, Next to EPIP Area, Kundalahalli, Whitefield Bengaluru-560066, Karnataka. Tel: + 91-80-49160700 , Mob: 9845355488 [ompany_logo] ___________________________________________________________________________________________________ This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it! ------------------------------------------------------------------------------------------------------------------------------------------------------------------- From: onap-discuss@lists.onap.org<mailto:onap-discuss@lists.onap.org> [mailto:onap-discuss@lists.onap.org] On Behalf Of TIMONEY, DAN Sent: Wednesday, January 09, 2019 10:58 PM To: onap-discuss Subject: [onap-discuss] Sonar "fixes" no longer accepted #ccsdk #sdnc CCSDK and SDNC team, We have recently had a large number (dozens) of reviews submitted to address ‘issues’ identified by Sonar. These issues have all been mostly what I would consider editorial in nature (e.g removing commented out code). While we like to welcome all contributions, we must also recognize that large numbers of changes which contribute no new functionality to the project present a burden to reviewers (e.g. I spent most of yesterday morning reviewing Sonar changes) and have frequently resulted in the past in breaking working code. Also, frequently things that Sonar identifies as “issues” are in fact project conventions (e.g. we have a project convention of calling our trace logger LOG – all caps – which Sonar complains about). I would ask that developers kindly not to submit code changes or open Jira tickets to address Sonar “issues” for the CCSDK or SDNC project. Such changes will no longer be merged. Please note that we will still gladly accept changes to increase test coverage as reported by Sonar. Thanks! Dan -- Dan Timoney Principal Technical Staff Member AT&T Email : dtimo...@att.com<mailto:dtimo...@att.com> Office : +1 (732) 420-3226 Mobile : +1 (201) 960-1211 200 S Laurel Ave, Rm E2-2A03 Middletown, NJ 08873 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14921): https://lists.onap.org/g/onap-discuss/message/14921 Mute This Topic: https://lists.onap.org/mt/28986504/21656 Mute #ccsdk: https://lists.onap.org/mk?hashtag=ccsdk&subid=2740164 Mute #sdnc: https://lists.onap.org/mk?hashtag=sdnc&subid=2740164 Group Owner: onap-discuss+ow...@lists.onap.org Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
