Hi Morgan,
I'm not sure if I get you right. Do you mean to put some functional test cases into the healthcheck tests by "improve them"? For now, I think readiness/liveness check is enought for the healthcheck of Holmes. For the function part, I want to keep it within the CSIT jobs. What's your opinion? Best Regards, Guangrong 原始邮件 发件人：MorganRichommevialists.onap.org 收件人：付光荣10144542;[email protected]; 抄送人：[email protected]; 日 期 ：2021年01月11日 18:58 主 题 ：[onap-discuss] [ONAP] [Honolulu] [Holmes] [Integration] Bringing Holmes healthcheck test back in CI? Hi, as Holmes was not part of Frankfurt, the healthcheck tests associated to Holmes had been removed. I wonder it it makes sense to reintegrate them as Holmes was part of Guilin and is part of Honolulu... For me it makes sense if these tests do more things than readiness/liveness probes. If not => the infrastructure tests are enough => no changes If so or if holmes team planned to improve them =>it is easy to reintegrate them. test given this morning on a guilin lab (using the tests declared in El Alto) ------------------------------------------------------------------------------ Basic Holmes Rule Management API Health Check | PASS | ------------------------------------------------------------------------------ Basic Holmes Engine Management API Health Check | PASS | But I did not dive into the code of the tests, so I am not sure it is more than we is tested at the infra level. @Guangrong Fu, Vijay what is your views? /Morgan _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22717): https://lists.onap.org/g/onap-discuss/message/22717 Mute This Topic: https://lists.onap.org/mt/79593043/21656 Group Owner: [email protected] Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
