Hi today there is no Holmes tests in daily/weekly/gating CI/CD - CI/CD chains e.g. last daily Guilin: https://logs.onap.org/onap-integration/daily/onap_daily_pod4_guilin/01-11-2021_05-01/ there are some on CSIT (functional tests) - I assume functionnal tests run in Maven (not very explicit on jenkins https://jenkins.onap.org/view/holmes/)
Until Dublin the 2 Holmes healthcheck (https://github.com/onap/testsuite/blob/el-alto/robot/testsuites/health-check.robot Lines 290-296) were included in CI/CD (health tag) but as Holmes was not in Frankfurt it was removed and not restored in Guilin. I finally had a look at the tests :) https://github.com/onap/testsuite/blob/master/robot/resources/holmes_interface.robot it looks like a simple healthcheck that is covered by the readiness/liveness probe in the CI/CD test dealing with infra In case of errors, we will get it in https://logs.onap.org/onap-integration/daily/onap_daily_pod4_guilin/01-11-2021_05-01/infrastructure-healthcheck/k8s/kubernetes-status/index.html so if the tests remain as they are now, there is no need to reintroduce them because they do not bring additional values. However healthcheck tests can be improved (because these healthcheck can be OK but the components not working as expected) and/or functional tests can be introduced in CI/CD in order to offer a better test during daily/weekly/gating chains. The better coverage we have in CI/CD, the more stability we have at the end. /Morgan ________________________________ De : onap-discuss@lists.onap.org [onap-discuss@lists.onap.org] de la part de Guangrong Fu [fu.guangr...@zte.com.cn] Envoyé : lundi 11 janvier 2021 12:32 À : morgan.richomme=orange....@lists.onap.org Cc : vv7...@att.com; onap-discuss@lists.onap.org Objet : Re: [onap-discuss] [ONAP] [Honolulu] [Holmes] [Integration] Bringing Holmes healthcheck test back in CI? Hi Morgan, I'm not sure if I get you right. Do you mean to put some functional test cases into the healthcheck tests by "improve them"? For now, I think readiness/liveness check is enought for the healthcheck of Holmes. For the function part, I want to keep it within the CSIT jobs. What's your opinion? Best Regards, Guangrong 原始邮件 发件人：MorganRichommevialists.onap.org 收件人：付光荣10144542;vv7...@att.com; 抄送人：onap-discuss@lists.onap.org; 日 期 ：2021年01月11日 18:58 主 题 ：[onap-discuss] [ONAP] [Honolulu] [Holmes] [Integration] Bringing Holmes healthcheck test back in CI? Hi, as Holmes was not part of Frankfurt, the healthcheck tests associated to Holmes had been removed. I wonder it it makes sense to reintegrate them as Holmes was part of Guilin and is part of Honolulu... For me it makes sense if these tests do more things than readiness/liveness probes. If not => the infrastructure tests are enough => no changes If so or if holmes team planned to improve them =>it is easy to reintegrate them. test given this morning on a guilin lab (using the tests declared in El Alto) ------------------------------------------------------------------------------ Basic Holmes Rule Management API Health Check | PASS | ------------------------------------------------------------------------------ Basic Holmes Engine Management API Health Check | PASS | But I did not dive into the code of the tests, so I am not sure it is more than we is tested at the infra level. @Guangrong Fu, Vijay what is your views? /Morgan _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22718): https://lists.onap.org/g/onap-discuss/message/22718 Mute This Topic: https://lists.onap.org/mt/79593043/21656 Group Owner: onap-discuss+ow...@lists.onap.org Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
