Dear Opasiak and Catherine,
I have noticed that the block thing of UUI’s merge into OOM is:
https://gerrit.onap.org/r/c/oom/+/118930
https://gerrit.onap.org/r/c/oom/+/119124
https://gerrit.onap.org/r/c/oom/+/119124
They’re all related to the new NLP server, however, since there’re some several problems appearing in these two commits, we accept the result to delay this new part to Istanbul release. We’ll abandon these two commits and make further changes. And the H release plan of UUI will NOT include this part.
As for the commit:
This commit only contains the changes of E2E slicing service which are some minor ones. We hope that OOM team can review this change and merge it. If there’s any problem with the E2E part, we’ll be free to change.
And also, Doctor @Dong Wang is the sponsor of the new NLP part, he is also available to response the problem of this part.
We will attend today’s PTL meeting to make some more explanation, hope we can reach an agreement.
B.R.
---------------------------------------------
Xu Ran
China Mobile Research Institute
No.32 Xuanwumen west street,Xicheng District, Beijing 100053, China
Mobile: +86 15010868144
Email: [email protected]
---------------------------------------------
Xu Ran
China Mobile Research Institute
No.32 Xuanwumen west street,Xicheng District, Beijing 100053, China
Mobile: +86 15010868144
Email: [email protected]
---------------------------------------------
On 03/27/2021 03:05,Krzysztof Opasiak via lists.onap.org<[email protected]> wrote:
Dear Catherine,
On 26.03.2021 19:13, Lefevre, Catherine wrote:
Dear OOM Team,
David and I we are trying to understand what it is left from OOM Backlog
that the project team(s) need to consider before the next PTL call (3/29)
We understand from the TSC call (3/25) - SO, SDNC and UUI had an action
but it was not clear that there were other projects.
Here is our understanding and the path to move forward.
After the following items are solved then we need to stabilize the
release and no more accept any OOM code submission except
for *versioning, documentation and show stoppers blocking E2E Testing.*
#1 UUI
Remaining code submitted to change version is
"https://gerrit.onap.org/r/c/oom/+/119844
<https://protect2.fireeye.com/v1/url?k=46b413cc-192f2ad6-46b59883-000babff24ad-7502168be2f1c9a9&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F119844>"
I have reviewed it and did not notice anything wrong so I believe it is
ready to merge
The UUI action was related to:
https://gerrit.onap.org/r/c/oom/+/118930
https://gerrit.onap.org/r/c/oom/+/119124
Not the patch that you linked above. The one that you linked has been
created *yesterday* 40 mins before the TSC meeting which is 4 weeks
after the deadline for starting OOM review with new containers for
Honolulu release.
In my personal opinion it's very unfair for other project teams to
accept such changes with a monthly delay. Think how much extra features
could CPS or DCAE Team implement if they had extra month for the
development...
The following items - we will follow-up if these are required for RC1
containers
It does not look like new code but more modifications of config to build
UUI Container. To be confirmed by *XU*
https://gerrit.onap.org/r/c/oom/+/118930
<https://protect2.fireeye.com/v1/url?k=a47f0bfc-fbe432e6-a47e80b3-000babff24ad-e702636d9b0b5453&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F118930>
https://gerrit.onap.org/r/c/oom/+/119124
<https://protect2.fireeye.com/v1/url?k=07a5321d-583e0b07-07a4b952-000babff24ad-6ac11a2aeca53cf1&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F119124>
This is a *brand new* microservice that they are willing to add to ONAP
It's not a change in config, it's not any kind of bugfix, it's a brand
new Helm chart under UUI project.
It was uploaded to gerrit a little bit after the deadline but it was
first sent to me via email so we decided to give it a chance.
Unfortunately when we start reviewing it more deeply multiple issues has
been discovered but never fixed and I believe that we cannot compromise
the quality because of the deadline.
#2 SO
We check the remaining open defects,
SO-3584 - https://gerrit.onap.org/r/c/oom/+/119522/11
<https://protect2.fireeye.com/v1/url?k=37e382ff-6878bbe5-37e209b0-000babff24ad-4af727887ea4b80c&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F119522%2F11>
(can we merge the code)?
As stated in the review, the patch itself is fine (that's why it has +2
from me and Sylvain) but we are waiting for a successful gating in
patch that you referred below as this is actually where SO will start
making use of that. If we merge it just now it would be just a blind
merge as without the patch above we don't know if it really works.
SO-3590 - https://gerrit.onap.org/r/c/oom/+/119309
<https://protect2.fireeye.com/v1/url?k=7c0eff7c-2395c666-7c0f7433-000babff24ad-9d6fd0d44e1a675a&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F119309>
(waiting for review)
Waiting for gating...
*SESHU, *
SO-3473
<https://protect2.fireeye.com/v1/url?k=e1cd66c7-be565fdd-e1cced88-000babff24ad-9b6b971174a78770&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fjira.onap.org%2Fbrowse%2FSO-3473>
- suggestion is to descope the remaining item of SO factoring to
Istanbul - too many code submitted and not yet reviewed.
SO-3553
<https://protect2.fireeye.com/v1/url?k=d2d706b8-8d4c3fa2-d2d68df7-000babff24ad-710911c68ded527a&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fjira.onap.org%2Fbrowse%2FSO-3553>
- https://gerrit.onap.org/r/c/oom/+/118331
<https://protect2.fireeye.com/v1/url?k=b5a00398-ea3b3a82-b5a188d7-000babff24ad-2c0d2ce12129518d&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F118331>
- can we descope and shift it to Istanbul?
CCSDK/SDNC
https://gerrit.onap.org/r/c/oom/+/118284
<https://protect2.fireeye.com/v1/url?k=b0398acd-efa2b3d7-b0380182-000babff24ad-4cd8bfca6accb446&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F118284>
-- (version update + 1 big fix) Dan T to review the comments from Morgan
I believe that Dan has already fixed the issue reported by Morgan. We
are waiting for gating to confirm this.
https://gerrit.onap.org/r/c/oom/+/117808
<https://protect2.fireeye.com/v1/url?k=c5400328-9adb3a32-c5418867-000babff24ad-e8cac77324f766a1&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F117808>
-- verified job ok, ready for review
I need to follow up with Alexander on this patch as I missed his
comment. Sorry for that.
CPS - OK For Honolulu
https://gerrit.onap.org/r/c/oom/+/118995
<https://protect2.fireeye.com/v1/url?k=1ce1defb-437ae7e1-1ce055b4-000babff24ad-f02eadf288773474&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F118995>
) verified job ok, ready for review
It's marked as WIP as Bruno is working to address comments from previous
revision. Nevertheless changes would not require releasing a new
container image. They just need to switch to use certInitializer for
their https termination on ingress.
Considering the progress that they made in this release, their nice
cooperation with us almost from the beginning of the release and amount
of comments that they addressed I believe that it's fair to take this
patch even as a bugfix after RC0 as it would affect OOM only
OOF - OK For Honolulu
https://gerrit.onap.org/r/c/oom/+/113414
<https://protect2.fireeye.com/v1/url?k=26742d43-79ef1459-2675a60c-000babff24ad-c6374855ff7d5692&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F113414>
verified job ok, ready for review
It's not ready, it doesn't work. I got some hint from Krishna how to fix
it so I'll give it a try this evening if it works we'll merge if not we
just postpone it. It's not a functional change it's just enabling
logging to STDOUT for OOF so I believe that it can be merge even after RC0
Holmes - What's level of confidence that it will work? Can we move this
to Istanbul.
https://gerrit.onap.org/r/c/oom/+/117395
<https://protect2.fireeye.com/v1/url?k=9235dd10-cdaee40a-9234565f-000babff24ad-c6d9314de228eb06&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F117395>
Guangrong Fu made recently some fixes but due to bad certs in DMAAP we
haven't had a chance to see it in the action. After we have gating
results we'll be able to say anything more.
AAI - OK For Honolulu (required for Certification)
https://gerrit.onap.org/r/c/oom/+/118248
<https://protect2.fireeye.com/v1/url?k=ef44ab91-b0df928b-ef4520de-000babff24ad-7bcfb89218b9c689&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F118248>
- verified job ok, ready for review
Waiting for gating results...
Code-wise looks fine. If it passes in the gating I'll merge it.
Multicloud - submitted before RC0
https://gerrit.onap.org/r/c/oom/+/119125
<https://protect2.fireeye.com/v1/url?k=ee9c325a-b1070b40-ee9db915-000babff24ad-e9894bd205478539&q=1&e=bb5ddae6-e181-4352-8e25-2bcfcc413086&u=https%3A%2F%2Fgerrit.onap.org%2Fr%2Fc%2Foom%2F%2B%2F119125>
- verified job ok, ready for review
Already reviewed;)
As I'm coauthor of this patch, Sylvain is the one to merge it but he is
waiting for jenkins job review before doing that. Code-wise looks fine
so as soon as we have results from jenkins I hope it can be merged.
*OOM Team*- do we miss anything else? THANK YOU
There is one more bugfix from the SDNC (CCSDK) team that has been
submitted yesterday:
https://gerrit.onap.org/r/c/oom/+/119847
I'm working with them to find the best solution but I'm sure we'll sort
this out quickly especially that it's just a change in the helm charts
that is easy to gate.
Best regards,
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
_._,_._,_
Links:
You receive all messages sent to this group.
View/Reply Online (#23072) | Reply To Group | Reply To Sender | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [[email protected]]
_._,_._,_
