OK. Iv'e committed it now. All known problems gone. Rick's change fixed
the problem with empty. The problem with delete not returning was due to me
reading the wrong page in the manual (the class method rather than the
instance method).
Docs to follow soon.
Jon
2008/9/16 Sahananda (Jon) Wolfers <[EMAIL PROTECTED]>
> Brilliant - I'll still commit my stuff when I get a chance.
>
>
> 2008/9/16 Rick McGuire <[EMAIL PROTECTED]>
>
>> Jon,
>>
>> I've not been able to reproduce the failure with delete, but the
>> RexxClearQueue API was not clearing the item count, resulting in
>> queued() incorrectly reporting the number of lines in the queue. I've
>> committed a fix for that.
>>
>> Rick
>>
>> On Tue, Sep 16, 2008 at 6:27 AM, Sahananda (Jon) Wolfers
>> <[EMAIL PROTECTED]> wrote:
>> > OK, I'll try to do a commit when I next find an access point.
>> >
>> > Jon
>> >
>> > 2008/9/16 Rick McGuire <[EMAIL PROTECTED]>
>> >>
>> >> Answers below
>> >>
>> >> On Tue, Sep 16, 2008 at 1:55 AM, Sahananda (Jon) Wolfers
>> >> <[EMAIL PROTECTED]> wrote:
>> >> > Hi guys,
>> >> >
>> >> > writing from the hotel bar, so perhaps not well formed questions.
>> >> >
>> >> > Test suite, as I understand it, assertequals looks for a non-strict
>> >> > equality, yet it fails when I compare the default rexxQueue with the
>> >> > string
>> >> > session.
>> >> >
>> >> > [failure] [20080915 11:29:03.468000]
>> >> > Test: TEST_GET
>> >> > Class: RexxQueue.testGroup
>> >> > File: D:\orxSVN\test\trunk\ooRexx\base\class\RexxQueue.testGroup
>> >> > Line: 249
>> >> > Failed: assertEquals
>> >> > Expected: [[SESSION], identityHash="242597249"]
>> >> > Actual: [[SESSION], identityHash="265817940"]
>> >> > Message: subtest 27: default queue named session
>> >> >
>> >>
>> >> I'd have to see what you're trying to do, but if you're doing a
>> >> comparison between a string value and an rxqueue instance, that's not
>> >> likely to compare equal.
>> >>
>> >>
>> >> > I'm not sure what the identity hash is, perhaps thar gives a clue.
>> >> >
>> >> > Also, if one uses the delete method of a named rexxqueue with items
>> >> > queued,
>> >> > the interpreter never seems to come back - at least in the context of
>> >> > the
>> >> > test suite. I don't think that can be down to my couple of changed
>> >> > lines of
>> >> > code?
>> >>
>> >> I doubt it. All of that code has been rewritten, so it could just be
>> >> a bug. If you have added a test case to the suite for that, at least
>> >> commit that so I have something to debug.
>> >>
>> >> >
>> >> > Also, Rick, I suspect that your rexx_clear_queue method doesn't clear
>> >> > the
>> >> > queue - but don't know how to debug it.
>> >>
>> >> It could be a bug in the backing API. Again, you might want to commit
>> >> the changes so I've got something to debug.
>> >>
>> >>
>> >> >
>> >> > there is a more general point here, given that I can't get my tiny
>> >> > changes
>> >> > to work, should I commit them anyway, knowing that they fail, so that
>> >> > others
>> >> > can point me in the right direction?
>> >>
>> >> I think it woulc be a good idea to go ahead and commit this. There
>> >> are likely bugs still lurking in the queuing code that still need to
>> >> be sorted out. The easiest way for me to debug something like that is
>> >> to have the actual code/test cases to work from.
>> >>
>> >> Rick
>> >>
>> >> >
>> >> > that's all for now. Keep up the good work,
>> >> >
>> >> > Jon
>> >> >
>> >> >
>> >> >
>> -------------------------------------------------------------------------
>> >> > This SF.Net email is sponsored by the Moblin Your Move Developer's
>> >> > challenge
>> >> > Build the coolest Linux based applications with Moblin SDK & win
>> great
>> >> > prizes
>> >> > Grand prize is a trip for two to an Open Source event anywhere in the
>> >> > world
>> >> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> >> > _______________________________________________
>> >> > Oorexx-devel mailing list
>> >> > [email protected]
>> >> > https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>> >> >
>> >> >
>> >>
>> >>
>> -------------------------------------------------------------------------
>> >> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> >> challenge
>> >> Build the coolest Linux based applications with Moblin SDK & win great
>> >> prizes
>> >> Grand prize is a trip for two to an Open Source event anywhere in the
>> >> world
>> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> >> _______________________________________________
>> >> Oorexx-devel mailing list
>> >> [email protected]
>> >> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>> >
>> >
>> >
>> -------------------------------------------------------------------------
>> > This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> > Build the coolest Linux based applications with Moblin SDK & win great
>> > prizes
>> > Grand prize is a trip for two to an Open Source event anywhere in the
>> world
>> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> > _______________________________________________
>> > Oorexx-devel mailing list
>> > [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>> >
>> >
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> Build the coolest Linux based applications with Moblin SDK & win great
>> prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the
>> world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Oorexx-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>
>
>
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Oorexx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
