On Tue, Jun 28, 2016 at 8:55 AM, Erich Steinböck <[email protected]
> wrote:
> What about this? Fixes the placement warnings, and all unit tests (except
> Ticker) seem to succeed.
>
> --- interpreter/memory/MemorySegment.hpp (revision 11066)
> +++ interpreter/memory/MemorySegment.hpp (working copy)
> @@ -174,7 +174,7 @@
> static const size_t LargeBlockThreshold =
> Memory::VeryLargeAllocationUnit;
> // Minimum size segment we'll allow
>
> - char segmentStart[8]; /* start of the object
> data */
> + char segmentStart[40]; /* start of the object
> data */
> };
>
> is this acceptable?
>
it might work. Make sure you test it on both 32-bit and 64-bit builds, as
the size of the DeadObject class will vary with the architecture. You
might even be able use one of the constants like MinimumObjectSize or
sizeof(DeadObject) rather than using the hardcoded size.
Rick
>
> On Tue, Jun 28, 2016 at 2:19 PM, Rick McGuire <[email protected]>
> wrote:
>
>>
>>
>> On Tue, Jun 28, 2016 at 8:15 AM, Erich Steinböck <
>> [email protected]> wrote:
>>
>>> I fixed a name clash between the new gcc 6 cmath and our oorexxapi.h
>>> (see revision [r11067]).
>>>
>>> It should build now also on gcc 6, with lots of warnings, though, one of
>>> which being really prominent:
>>>
>>> main/trunk/interpreter/memory/MemorySegment.hpp:139:56: warning:
>>> placement new constructing an object of type ‘DeadObject’ and size ‘40’ in
>>> a region of type ‘char [8]’ and size ‘8’ [-Wplacement-new=]
>>> inline DeadObject *createDeadObject() { return new ((void
>>> *)segmentStart) DeadObject(segmentSize); }
>>>
>>> ^~~~~~~~~~~~~~~~~~~~
>>>
>>> Any suggestions, how I'd best fix that, without breaking anything,
>>> please ... :-)
>>>
>>
>> You might try breaking that up into two statements where you assign a
>> temp variable to the address of segment start and use the temp variable to
>> instantiate the object.
>>
>> Rick
>>
>>>
>>>
>>> Erich
>>>
>>> On Tue, Jun 28, 2016 at 11:41 AM, Rick McGuire <[email protected]>
>>> wrote:
>>>
>>>> Do you have a pointer to the description of the new restrictions? This
>>>> essentially makes macros useless for a lot of purposes. Also, I suspect
>>>> there might be something else going on here, because RexxMethod1 and
>>>> wholenumber_t should most definitely be defined by that point.
>>>>
>>>> Rick
>>>>
>>>> On Mon, Jun 27, 2016 at 11:19 PM, Erico Mendonca <
>>>> [email protected]> wrote:
>>>>
>>>>> >
>>>>> >Is the problem with the token OPTIONAL_RexxStringObject? The fix
>>>>> could be a
>>>>> >simple as adding some additional defines for all of the OPTIONAL_*
>>>>> types at
>>>>> >the top of oorexxapi.h.
>>>>> >
>>>>>
>>>>> Not only that. In this call, for example:
>>>>>
>>>>> RexxMethod1(wholenumber_t, rexx_queue_queue,
>>>>> OPTIONAL_RexxStringObject, queue_line)
>>>>>
>>>>> GCC will complain about every one of the elements not being a valid
>>>>> token, like RexxMethod1, wholenumber_t, rexx_queue_queue...
>>>>>
>>>>> --
>>>>> — Erico Mendonça
>>>>>
>>>>> Dedicated Support Engineer
>>>>> SUSE
>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>>>>> Francisco, CA to explore cutting-edge tech and listen to tech
>>>>> luminaries
>>>>> present their vision of the future. This family event has something for
>>>>> everyone, including kids. Get more information and register today.
>>>>> http://sdm.link/attshape
>>>>> _______________________________________________
>>>>> Oorexx-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>>>>
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>>>> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
>>>> present their vision of the future. This family event has something for
>>>> everyone, including kids. Get more information and register today.
>>>> http://sdm.link/attshape
>>>> _______________________________________________
>>>> Oorexx-devel mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>>> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
>>> present their vision of the future. This family event has something for
>>> everyone, including kids. Get more information and register today.
>>> http://sdm.link/attshape
>>> _______________________________________________
>>> Oorexx-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
>> present their vision of the future. This family event has something for
>> everyone, including kids. Get more information and register today.
>> http://sdm.link/attshape
>> _______________________________________________
>> Oorexx-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
> present their vision of the future. This family event has something for
> everyone, including kids. Get more information and register today.
> http://sdm.link/attshape
> _______________________________________________
> Oorexx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
>
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Oorexx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
