-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2447
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/2274/#comment5555>

    formatting pls. why in three lines?



trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5556>

    remove spaces



trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5558>

    Does not fit into command classes.
    
    It could be a separate utility class or a private methods in the 
coordinatorEngine.



trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5557>

    spaces pls


- Mohammad


On 2011-10-07 22:15:25, Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 22:15:25)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> This is on behalf of Kiran N.'s work on oozie logs
> 
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 
> 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1179918 
>   trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
> 1179918 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1179918 
>   
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java
>  PRE-CREATION 
>   
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java
>  PRE-CREATION 
>   trunk/release-log.txt 1179918 
> 
> Diff: https://reviews.apache.org/r/2274/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mona
> 
>

Reply via email to