----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2274/#review2629 -----------------------------------------------------------
Minor comments. Otherwise its good to go. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java <https://reviews.apache.org/r/2274/#comment5937> It should be date range instead of date's range. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java <https://reviews.apache.org/r/2274/#comment5938> It should be date range instead of date's range. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java <https://reviews.apache.org/r/2274/#comment5939> It should be date range instead of date's range. trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java <https://reviews.apache.org/r/2274/#comment5935> Operator precedence will take care of the division prior to the subtraction. For code clarity, its better to do the following: (nominalTimeMilliseconds - (noOfMilliseconds inOneHour / 2)) trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java <https://reviews.apache.org/r/2274/#comment5936> Operator precedence will take care of the division prior to the subtraction. For code clarity, its better to do the following: (nominalTimeMilliseconds + (noOfMilliseconds inOneHour / 2)) - Santhosh On 2011-10-17 19:59:01, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2274/ > ----------------------------------------------------------- > > (Updated 2011-10-17 19:59:01) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This is on behalf of Kiran N.'s work on oozie logs > > Date range for log retrieval > - User can add the command line option -date(Ex.: -date > 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1181286 > trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java > PRE-CREATION > trunk/release-log.txt 1181286 > > Diff: https://reviews.apache.org/r/2274/diff > > > Testing > ------- > > > Thanks, > > Mona > >
