----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2573/#review2989 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6704> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6705> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6701> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6702> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6706> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6707> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6708> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6709> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6711> tailing space trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetPendingActionsCountJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6712> tailing space trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java <https://reviews.apache.org/r/2573/#comment6713> why waste any db search of pending count when you already another query to get pending=false? If you see no item in coordActStatus, then continue. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6715> tailing space trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6717> tailing space trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6716> tailing space trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6718> tailing space trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6719> tailing space trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6720> tailing space - Angelo K. On 2011-10-31 16:58:25, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2573/ > ----------------------------------------------------------- > > (Updated 2011-10-31 16:58:25) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > Bug oozie-587 > Summary: https://issues.apache.org/jira/browse/OOZIE-587 > > > This addresses bug OOZIE-587. > https://issues.apache.org/jira/browse/OOZIE-587 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusByPendingFalseJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetPendingActionsCountJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1189491 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java > PRE-CREATION > trunk/release-log.txt 1189491 > > Diff: https://reviews.apache.org/r/2573/diff > > > Testing > ------- > > Added test cases for JPAExecutor. Tested against current test cases. > > > Thanks, > > Virag > >
