----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2573/#review3029 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/2573/#comment6748> changed to earlier format trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/2573/#comment6749> comments added trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/2573/#comment6750> changed to old one trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java <https://reviews.apache.org/r/2573/#comment6751> wf job doesn't timeout trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java <https://reviews.apache.org/r/2573/#comment6752> Good point. But the debug statements are virtually in every file. The check whether debug is enabled or not will reduce readability of code trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java <https://reviews.apache.org/r/2573/#comment6753> The current code base has else in the next line. Also the formatter is designed to put else in the next line. trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java <https://reviews.apache.org/r/2573/#comment6754> confusing variable names removed trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java <https://reviews.apache.org/r/2573/#comment6755> moved trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java <https://reviews.apache.org/r/2573/#comment6756> This is a comment in context. Can you plz read the comments 5 lines above to understand this comment trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6757> removed trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6758> extra comment added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6759> comment added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6760> comment added. Null is requred trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6761> english corrected trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6762> moved trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6763> added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6764> comment added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6765> comment added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6766> comment added trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6767> comment added trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java <https://reviews.apache.org/r/2573/#comment6768> pending query is required. Clarifying comment added trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6769> not requried trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6770> comments added trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6771> not necessary trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6772> moved trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java <https://reviews.apache.org/r/2573/#comment6773> checked in the test case which checks sql selection operator - Virag On 2011-10-31 16:58:25, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2573/ > ----------------------------------------------------------- > > (Updated 2011-10-31 16:58:25) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > Bug oozie-587 > Summary: https://issues.apache.org/jira/browse/OOZIE-587 > > > This addresses bug OOZIE-587. > https://issues.apache.org/jira/browse/OOZIE-587 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java > 1189491 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusByPendingFalseJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetPendingActionsCountJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1189491 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java > PRE-CREATION > trunk/release-log.txt 1189491 > > Diff: https://reviews.apache.org/r/2573/diff > > > Testing > ------- > > Added test cases for JPAExecutor. Tested against current test cases. > > > Thanks, > > Virag > >
