-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2802/#review3202
-----------------------------------------------------------


Pls add a release.log entry.


/trunk/core/src/main/java/org/apache/oozie/service/Services.java
<https://reviews.apache.org/r/2802/#comment7100>

    Although the last one is replacing, the first one is also initialized (in 
line 237).
    
    Alternatively, can't we do the replacement before instantiation of the 
replaced service class. Wandering if that could create any side-effect.


- Mohammad


On 2011-11-11 01:32:42, Alejandro Abdelnur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2802/
> -----------------------------------------------------------
> 
> (Updated 2011-11-11 01:32:42)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> The patch loads all services classes, initializes them to find out the 
> service interface and keeps the latest one, after that only the final ones 
> are initialized.
> 
> This will address the problem of the 
> HadoopAccessorService/KerberosAccessorService
> 
> 
> This addresses bug OOZIE-480.
>     https://issues.apache.org/jira/browse/OOZIE-480
> 
> 
> Diffs
> -----
> 
>   /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683 
>   /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683 
>   /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 
> 1200683 
> 
> Diff: https://reviews.apache.org/r/2802/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alejandro
> 
>

Reply via email to