> On 2011-11-14 07:25:55, Mohammad Islam wrote: > > Pls add a release.log entry.
Wouldn't make more sense (as it is done in Hadoop as well) that the committer edits the release log at commit time? This would avoid unnecessary conflicts when patches are committed out of order. > On 2011-11-14 07:25:55, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/Services.java, line 284 > > <https://reviews.apache.org/r/2802/diff/1/?file=57459#file57459line284> > > > > Although the last one is replacing, the first one is also initialized > > (in line 237). > > > > Alternatively, can't we do the replacement before instantiation of the > > replaced service class. Wandering if that could create any side-effect. not possible to do so as we need to instantiate the service to find the interface it implements. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2802/#review3202 ----------------------------------------------------------- On 2011-11-11 01:32:42, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2802/ > ----------------------------------------------------------- > > (Updated 2011-11-11 01:32:42) > > > Review request for oozie. > > > Summary > ------- > > The patch loads all services classes, initializes them to find out the > service interface and keeps the latest one, after that only the final ones > are initialized. > > This will address the problem of the > HadoopAccessorService/KerberosAccessorService > > > This addresses bug OOZIE-480. > https://issues.apache.org/jira/browse/OOZIE-480 > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683 > /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683 > /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java > 1200683 > > Diff: https://reviews.apache.org/r/2802/diff > > > Testing > ------- > > > Thanks, > > Alejandro > >
