[
https://issues.apache.org/jira/browse/OOZIE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159181#comment-13159181
]
[email protected] commented on OOZIE-68:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2927/#review3496
-----------------------------------------------------------
/trunk/client/src/main/resources/hive-action-0.2.xsd
<https://reviews.apache.org/r/2927/#comment7925>
why move is not supported?
/trunk/core/src/main/conf/oozie-site.xml
<https://reviews.apache.org/r/2927/#comment7926>
space
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/2927/#comment7927>
what is the value of using proto conf here?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
<https://reviews.apache.org/r/2927/#comment7928>
space
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7929>
Minor stuff. It might be better to use the variable "HIVE_SCRIPT" in place
of hard-coding.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7778>
the file name will be oozie-user-hive-default.xml?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7930>
'dummy' file is needed to get the current directory. is it the only reason?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7931>
is it parameter 'key' or 'value' ? Sounds 'key' or 'var' more appropriate.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7932>
is it possible 'val' could be empty? Any special checks needed? Or 'null'
is valid value?
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7933>
closing the BufferedReader might be safer in try{} finally{br.close()}
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
<https://reviews.apache.org/r/2927/#comment7934>
call it in try {}finall{os.close()} could be better
/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
<https://reviews.apache.org/r/2927/#comment7935>
what is the usage of 'conf' parameter?
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
<https://reviews.apache.org/r/2927/#comment7936>
is there any non-proprietary equivalent stuff there?
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java
<https://reviews.apache.org/r/2927/#comment7937>
if not intended, please take out this file.
/trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java
<https://reviews.apache.org/r/2927/#comment7938>
Wandering how come it was working?
/trunk/docs/src/site/twiki/ENG_Building.twiki
<https://reviews.apache.org/r/2927/#comment7939>
space
- Mohammad
On 2011-11-23 21:59:10, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2927/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-23 21:59:10)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. OOZIE-68 Add Hive Action
bq.
bq.
bq. This addresses bug OOZIE-68.
bq. https://issues.apache.org/jira/browse/OOZIE-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/.gitignore 1205620
bq. /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1205620
bq. /trunk/client/src/main/resources/hive-action-0.2.xsd PRE-CREATION
bq. /trunk/core/pom.xml 1205620
bq. /trunk/core/src/main/conf/oozie-site.xml 1205620
bq. /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
PRE-CREATION
bq. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
PRE-CREATION
bq. /trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitCommand.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
PRE-CREATION
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java
PRE-CREATION
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1205620
bq. /trunk/core/src/test/resources/user-hive-default.xml PRE-CREATION
bq. /trunk/docs/src/site/twiki/DG_HiveActionExtension.twiki PRE-CREATION
bq. /trunk/docs/src/site/twiki/ENG_Building.twiki 1205620
bq. /trunk/docs/src/site/twiki/index.twiki 1205620
bq. /trunk/examples/pom.xml 1205620
bq. /trunk/examples/src/main/apps/hive/job.properties PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/my-hive-default.xml PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/script.q PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/workflow.xml PRE-CREATION
bq.
/trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java
1205620
bq. /trunk/pom.xml 1205620
bq. /trunk/sharelib/hive/pom.xml PRE-CREATION
bq. /trunk/sharelib/pom.xml 1205620
bq. /trunk/src/main/assemblies/sharelib.xml 1205620
bq.
bq. Diff: https://reviews.apache.org/r/2927/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Note that hive testcases are excluded by default and to run the you have
to do:
bq.
bq. mvn -DtestHive -Dtest=TestHiveActionExecutor,TestHiveMain
bq.
bq. This is mentioned in the ENG_Building twiki.
bq.
bq. The reason for this is the dependency conflict between pig and hive
regarding antlr
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> Add Hive action
> ---------------
>
> Key: OOZIE-68
> URL: https://issues.apache.org/jira/browse/OOZIE-68
> Project: Oozie
> Issue Type: Bug
> Reporter: Hadoop QA
> Assignee: Alejandro Abdelnur
> Attachments: OOZIE-68v1.patch, OOZIE-68v2.patch
>
>
> Original issue: GH-22
> Add support for Hive actions in workflows.
> This would be via a new action executor and an extension schema.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
