[
https://issues.apache.org/jira/browse/OOZIE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159419#comment-13159419
]
[email protected] commented on OOZIE-68:
----------------------------------------------------
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/conf/oozie-site.xml, line 25
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59983#file59983line25>
bq. >
bq. > space
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java,
line 139
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59985#file59985line139>
bq. >
bq. > what is the value of using proto conf here?
with some versions of Hadoop kerberos name rules are not part of the default
configuration, using the proto action conf ensures they always are there.
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java,
line 135
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59986#file59986line135>
bq. >
bq. > space
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 175
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line175>
bq. >
bq. > Minor stuff. It might be better to use the variable "HIVE_SCRIPT" in
place of hard-coding.
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 182
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line182>
bq. >
bq. > the file name will be oozie-user-hive-default.xml?
On the HiveMain side is always this name, the HiveActionExecutor copies with
this name.
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 211
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line211>
bq. >
bq. > 'dummy' file is needed to get the current directory. is it the only
reason?
this is a common way of finding the current dir
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 241
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line241>
bq. >
bq. > is it parameter 'key' or 'value' ? Sounds 'key' or 'var' more
appropriate.
this is the hive action <param> thus it should be param
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 244
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line244>
bq. >
bq. > is it possible 'val' could be empty? Any special checks needed? Or
'null' is valid value?
it can be empty but it cannot be null
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 316
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line316>
bq. >
bq. > closing the BufferedReader might be safer in try{}
finally{br.close()}
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java,
line 323
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line323>
bq. >
bq. > call it in try {}finall{os.close()} could be better
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java,
line 101
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59990#file59990line101>
bq. >
bq. > what is the usage of 'conf' parameter?
this is odd, as LiteWorkflowAppService calls using the conf but is not in the
diff.
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java,
line 74
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59991#file59991line74>
bq. >
bq. > is there any non-proprietary equivalent stuff there?
No, this is hive land
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java,
line 58
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59993#file59993line58>
bq. >
bq. > if not intended, please take out this file.
k
bq. On 2011-11-29 10:06:50, Mohammad Islam wrote:
bq. >
/trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java,
line 60
bq. > <https://reviews.apache.org/r/2927/diff/1/?file=59994#file59994line60>
bq. >
bq. > Wandering how come it was working?
don't know
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2927/#review3496
-----------------------------------------------------------
On 2011-11-23 21:59:10, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2927/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-23 21:59:10)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. OOZIE-68 Add Hive Action
bq.
bq.
bq. This addresses bug OOZIE-68.
bq. https://issues.apache.org/jira/browse/OOZIE-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/.gitignore 1205620
bq. /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1205620
bq. /trunk/client/src/main/resources/hive-action-0.2.xsd PRE-CREATION
bq. /trunk/core/pom.xml 1205620
bq. /trunk/core/src/main/conf/oozie-site.xml 1205620
bq. /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java
PRE-CREATION
bq. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java
PRE-CREATION
bq. /trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitCommand.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java
1205620
bq.
/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
PRE-CREATION
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java
PRE-CREATION
bq.
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java
1205620
bq.
/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1205620
bq. /trunk/core/src/test/resources/user-hive-default.xml PRE-CREATION
bq. /trunk/docs/src/site/twiki/DG_HiveActionExtension.twiki PRE-CREATION
bq. /trunk/docs/src/site/twiki/ENG_Building.twiki 1205620
bq. /trunk/docs/src/site/twiki/index.twiki 1205620
bq. /trunk/examples/pom.xml 1205620
bq. /trunk/examples/src/main/apps/hive/job.properties PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/my-hive-default.xml PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/script.q PRE-CREATION
bq. /trunk/examples/src/main/apps/hive/workflow.xml PRE-CREATION
bq.
/trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java
1205620
bq. /trunk/pom.xml 1205620
bq. /trunk/sharelib/hive/pom.xml PRE-CREATION
bq. /trunk/sharelib/pom.xml 1205620
bq. /trunk/src/main/assemblies/sharelib.xml 1205620
bq.
bq. Diff: https://reviews.apache.org/r/2927/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Note that hive testcases are excluded by default and to run the you have
to do:
bq.
bq. mvn -DtestHive -Dtest=TestHiveActionExecutor,TestHiveMain
bq.
bq. This is mentioned in the ENG_Building twiki.
bq.
bq. The reason for this is the dependency conflict between pig and hive
regarding antlr
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> Add Hive action
> ---------------
>
> Key: OOZIE-68
> URL: https://issues.apache.org/jira/browse/OOZIE-68
> Project: Oozie
> Issue Type: Bug
> Reporter: Hadoop QA
> Assignee: Alejandro Abdelnur
> Attachments: OOZIE-68v1.patch, OOZIE-68v2.patch
>
>
> Original issue: GH-22
> Add support for Hive actions in workflows.
> This would be via a new action executor and an extension schema.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
