----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2927/#review3558 -----------------------------------------------------------
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2927/#comment7943> with some versions of hadoop there were failures as not Kerberos rules were avail. This ensures the Kerberos rules are there. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7944> this is in the HiveMain class invoked in the launcher, the HiveActionExecutor will always set the same name for the defaults file /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7945> yes, this is a common trick to find out the current directory for the process. /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7946> this are the <param> of the hive action, param is appropriate /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7947> param cannot be null, it can be empty string but not null /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7948> k /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java <https://reviews.apache.org/r/2927/#comment7949> k /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/2927/#comment7950> spurious change, will remove /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java <https://reviews.apache.org/r/2927/#comment7951> no, this is hive stuff /trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java <https://reviews.apache.org/r/2927/#comment7952> me too - Alejandro On 2011-11-23 21:59:10, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2927/ > ----------------------------------------------------------- > > (Updated 2011-11-23 21:59:10) > > > Review request for oozie. > > > Summary > ------- > > OOZIE-68 Add Hive Action > > > This addresses bug OOZIE-68. > https://issues.apache.org/jira/browse/OOZIE-68 > > > Diffs > ----- > > /trunk/.gitignore 1205620 > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1205620 > /trunk/client/src/main/resources/hive-action-0.2.xsd PRE-CREATION > /trunk/core/pom.xml 1205620 > /trunk/core/src/main/conf/oozie-site.xml 1205620 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1205620 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1205620 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitCommand.java > 1205620 > > /trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java > 1205620 > /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1205620 > > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java > 1205620 > > /trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java > 1205620 > > /trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1205620 > /trunk/core/src/test/resources/user-hive-default.xml PRE-CREATION > /trunk/docs/src/site/twiki/DG_HiveActionExtension.twiki PRE-CREATION > /trunk/docs/src/site/twiki/ENG_Building.twiki 1205620 > /trunk/docs/src/site/twiki/index.twiki 1205620 > /trunk/examples/pom.xml 1205620 > /trunk/examples/src/main/apps/hive/job.properties PRE-CREATION > /trunk/examples/src/main/apps/hive/my-hive-default.xml PRE-CREATION > /trunk/examples/src/main/apps/hive/script.q PRE-CREATION > /trunk/examples/src/main/apps/hive/workflow.xml PRE-CREATION > > /trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java > 1205620 > /trunk/pom.xml 1205620 > /trunk/sharelib/hive/pom.xml PRE-CREATION > /trunk/sharelib/pom.xml 1205620 > /trunk/src/main/assemblies/sharelib.xml 1205620 > > Diff: https://reviews.apache.org/r/2927/diff > > > Testing > ------- > > Note that hive testcases are excluded by default and to run the you have to > do: > > mvn -DtestHive -Dtest=TestHiveActionExecutor,TestHiveMain > > This is mentioned in the ENG_Building twiki. > > The reason for this is the dependency conflict between pig and hive regarding > antlr > > > Thanks, > > Alejandro > >
